Cleanup RoomList UI ops

Review Request #785 — Created July 1, 2021 and submitted

QuLogic
pidgin/pidgin
default
pidgin
  • Mark unused parameters, and remove unnecessary widgets passed to callbacks.
  • Remove unused purple_roomlist_[gs]et_protocol_data.
  • Remove unused list of PurpleRoomLists.
  • Inline update_roomlist using GObject macros.
  • Remove use of PurpleRoomListUiOps->destroy.
    This can be achieved through object destruction notifiers.
    I'm not sure how the room list would ever get destroyed in Finch though, as the
    widget seems to hold a ref to it, which is cleared when the list is destroyed.
    But the list can't be destroyed until said ref is dropped.
  • Replace PurpleRoomlistUiOps->in_progress with notify signals.

Compile only. Might have done some tests, but I wrote this a while back and don't remember.

grim
  1. Ship It!
  2. Nice work, is the Ui object next?

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...