-
-
pidgin/pidgintextbuffer.c (Diff revision 1) Normally
GtkTextIter
is intended to be allocated on the stack (no*
.) -
pidgin/pidgintextbuffer.c (Diff revision 1) And then copies are just
position = *start; next = *start;
. (See docs ofgtk_text_iter_copy
.) -
-
-
-
pidgin/tests/test_text_buffer.c (Diff revision 1) Not sure I understand the comment, as you still use
markup
as the expected result?
Create pidgin_text_buffer API for working with GtkTextBuffers
Review Request #2754 — Created Oct. 31, 2023 and submitted
Currently we only implement _get_html and _get_html_range and only a subset of html tags are identified properly. This was intentional as it's easy to add additional tags and because we're also introducing testing to Pidgin in this commit.
Ran the unit tests under valgrind without issues.
Summary | ID |
---|---|
12e09c3c44bdb04e36f4758d0ad3921b60c2ab16 |
Description | From | Last Updated |
---|---|---|
Normally GtkTextIter is intended to be allocated on the stack (no *.) |
QuLogic | |
And then copies are just position = *start; next = *start;. (See docs of gtk_text_iter_copy.) |
QuLogic | |
Not talkatu. |
QuLogic | |
Usually Python3 would be 4-space indent. |
QuLogic | |
Extra space before =. |
QuLogic | |
Not sure I understand the comment, as you still use markup as the expected result? |
QuLogic | |
So it doesn't seem like end/real_end are used after this? |
QuLogic |
Change Summary:
rebased and addressed issue.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+866) |
-
-
pidgin/pidgintextbuffer.c (Diff revision 2) So it doesn't seem like
end
/real_end
are used after this?
Change Summary:
Added a test for ranges and made it pass.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+984) |