Replace Talkatu in the notify api

 






 

 


  Review Request #2750
  —
  Created Oct. 29, 2023 and submitted 

 




















 

  

   Information

  





 
 

  grim
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  2754
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
Replace Talkatu in the notify api

 








  


 
 

  
Used some turtle power.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     
Replace Talkatu in the notify api


    		
    9f4b1e83177c8309dfa52613ee6599cbd558c6a5

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
This change drops support for html formatting in notify_formatted. For example, without the changes of this RR calling purple_notify_formatted(NULL, "title", …

      		
      
       ivanhoeivanhoe
      
      
       
      
     




     

      
       
       
ag unused

      		
      
       ivanhoeivanhoe
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




ivanhoe




   

   







  

 



 

  


   

   

    
 
ivanhoe


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      pidgin/gtknotify.c
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    ag unused
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




ivanhoe




   

   







  

 



 

  


   

   

    
 
ivanhoe


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    This change drops support for html formatting in notify_formatted.
    

    For example, without the changes of this RR calling purple_notify_formatted(NULL, "title", "primary", "secondary", "some <b>bold</b> text", NULL, NULL); would print the word "bold" as bold text. Now, with the changes of this RR, it prints some <b>bold</b> text literally.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      At this a bit closer there's some outstanding issues if I change this from gtk_text_buffer_set_text to gtk_text_buffer_insert_markup and that is that the purple_markup_linkify before it is going to case gtk_text_buffer_insert_markup to fail if there's a link.
      

      Are we okay with that for now? If so, then I'll make the change, otherwise we'll need to do what GtkLabel does and add a PangoMarkupParser to handle the links on insert and then update pidgin_text_buffer_get_html to handle those links. It's doable, but maybe we should do that in another rr?
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I would be ok with this.
      
 
      

      3. 


 
    


    

 
    

    3. 













  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




ivanhoe




   

   







  

 



 

  


   

   

    
 
ivanhoe


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...