Summary

Create pidgin_text_buffer API for working with GtkTextBuffers

Review Request #2754 — Created Oct. 30, 2023 and submitted Oct. 31, 2023, 1:14 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

2750

Reviewers

Groups

pidgin

People

Description

Currently we only implement _get_html and _get_html_range and only a subset of
html tags are identified properly. This was intentional as it's easy to add
additional tags and because we're also introducing testing to Pidgin in this
commit.

Testing Done

Ran the unit tests under valgrind without issues.

Commits

Summary	ID
Create pidgin_text_buffer API for working with GtkTextBuffers Currently we only implement _get_html and _get_html_range and only a subset of html tags are identified properly. This was intentional as it's easy to add additional tags and because we're also introducing testing to Pidgin in this commit.	12e09c3c44bdb04e36f4758d0ad3921b60c2ab16

Issues

Description	From	Last Updated
Normally GtkTextIter is intended to be allocated on the stack (no *.)	QuLogic	Oct. 31, 2023, 12:15 a.m.
And then copies are just position = start; next = start;. (See docs of gtk_text_iter_copy.)	QuLogic	Oct. 31, 2023, 12:18 a.m.
Not talkatu.	QuLogic	Oct. 31, 2023, 12:18 a.m.
Usually Python3 would be 4-space indent.	QuLogic	Oct. 31, 2023, 12:18 a.m.
Extra space before =.	QuLogic	Oct. 31, 2023, 12:18 a.m.
Not sure I understand the comment, as you still use markup as the expected result?	QuLogic	Oct. 31, 2023, 12:18 a.m.
So it doesn't seem like end/real_end are used after this?	QuLogic	Oct. 31, 2023, 12:57 a.m.

pidgin/pidgintextbuffer.c (Diff revision 1)

The issue has been resolved. Show all issues

Normally GtkTextIter is intended to be allocated on the stack (no *.)

grim Oct. 30, 2023, 11:41 p.m.

The intent was that I wanted copies of the passed in ones, but I should I can copy by value them...

pidgin/pidgintextbuffer.c (Diff revision 1)

The issue has been resolved. Show all issues

And then copies are just position = *start; next = *start;. (See docs of gtk_text_iter_copy.)

pidgin/tests/test-wrapper.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Not talkatu.
```
pidgin/tests/test-wrapper.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Usually Python3 would be 4-space indent.
```
pidgin/tests/test-wrapper.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Extra space before =.
```

pidgin/tests/test_text_buffer.c (Diff revision 1)

The issue has been resolved. Show all issues

Not sure I understand the comment, as you still use markup as the expected result?

grim Oct. 30, 2023, 11:41 p.m.
```
This was supposed to be deleted.
```

Change Summary:

rebased and addressed issue.

Commits:

	Summary	ID
	Create pidgin_text_buffer API for working with GtkTextBuffers Currently we only implement _get_html and _get_html_range and only a subset of html tags are identified properly. This was intentional as it's easy to add additional tags and because we're also introducing testing to Pidgin in this commit.	6f86b0dcb54dd0bf3386f2f382ada9c2401d8f37
	Create pidgin_text_buffer API for working with GtkTextBuffers Currently we only implement _get_html and _get_html_range and only a subset of html tags are identified properly. This was intentional as it's easy to add additional tags and because we're also introducing testing to Pidgin in this commit.	26571cda37697f7adde3f3c3863c0799a1be8385

Diff:

Revision 2 (+866)

Show changes

	pidgin/meson.build
	pidgin/pidgintextbuffer.h
	pidgin/pidgintextbuffer.c
	pidgin/tests/meson.build
	pidgin/tests/test-wrapper.py
	pidgin/tests/test_text_buffer.c

pidgin/pidgintextbuffer.c (Diff revision 2)
The issue has been resolved. Show all issues
```
So it doesn't seem like end/real_end are used after this?
```

Change Summary:

Added a test for ranges and made it pass.

Commits:

	Summary	ID
	Create pidgin_text_buffer API for working with GtkTextBuffers Currently we only implement _get_html and _get_html_range and only a subset of html tags are identified properly. This was intentional as it's easy to add additional tags and because we're also introducing testing to Pidgin in this commit.	26571cda37697f7adde3f3c3863c0799a1be8385
	Create pidgin_text_buffer API for working with GtkTextBuffers Currently we only implement _get_html and _get_html_range and only a subset of html tags are identified properly. This was intentional as it's easy to add additional tags and because we're also introducing testing to Pidgin in this commit.	12e09c3c44bdb04e36f4758d0ad3921b60c2ab16

Diff:

Revision 3 (+984)

Show changes

	pidgin/meson.build
	pidgin/pidgintextbuffer.h
	pidgin/pidgintextbuffer.c
	pidgin/tests/meson.build
	pidgin/tests/test-wrapper.py
	pidgin/tests/test_text_buffer.c

Ship it!

```
Ship It!
```

Status:: Completed