Summary

Replace Talkatu in the notify api

Review Request #2750 — Created Oct. 29, 2023 and submitted Nov. 7, 2023, 7:23 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~2754~~

Reviewers

Groups

pidgin

People

Description

Replace Talkatu in the notify api

Testing Done

Used some turtle power.

Commits

Summary	ID
Replace Talkatu in the notify api	9f4b1e83177c8309dfa52613ee6599cbd558c6a5

Issues

Description	From	Last Updated
This change drops support for html formatting in notify_formatted. For example, without the changes of this RR calling purple_notify_formatted(NULL, "title", …	ivanhoe	Nov. 7, 2023, 7:07 a.m.
ag unused	ivanhoe	Nov. 7, 2023, 7:06 a.m.

pidgin/gtknotify.c (Diff revision 1)
The issue has been resolved. Show all issues
```
ag unused
```

The issue has been dropped. Show all issues

This change drops support for html formatting in notify_formatted.
For example, without the changes of this RR calling purple_notify_formatted(NULL, "title", "primary", "secondary", "some <b>bold</b> text", NULL, NULL); would print the word "bold" as bold text. Now, with the changes of this RR, it prints some <b>bold</b> text literally.

grim Nov. 1, 2023, 8:46 a.m.

At this a bit closer there's some outstanding issues if I change this from gtk_text_buffer_set_text to gtk_text_buffer_insert_markup and that is that the purple_markup_linkify before it is going to case gtk_text_buffer_insert_markup to fail if there's a link.

Are we okay with that for now? If so, then I'll make the change, otherwise we'll need to do what GtkLabel does and add a PangoMarkupParser to handle the links on insert and then update pidgin_text_buffer_get_html to handle those links. It's doable, but maybe we should do that in another rr?

ivanhoe Nov. 3, 2023, 8:17 p.m.
```
I would be ok with this.
```

Change Summary:: add /r/2754 as a dependency to keep the html support around.
Depends On:: ~~2754 - Create pidgin_text_buffer API for working with GtkTextBuffers~~

Change Summary:

rebased and removed the unused ag variable.

Commits:

	Summary	ID
	Replace Talkatu in the notify api	26deac07143f6b3a9bc5d80511a575545e34e62b
	Replace Talkatu in the notify api	9f4b1e83177c8309dfa52613ee6599cbd558c6a5

Diff:

Revision 2 (+10 -20)

Show changes

pidgin/gtknotify.c

Ship it!

```
Ship It!
```

Status:: Completed

pidgin/gtknotify.c (Diff revision 1)