Summary

Add tooltips to timestamps in PidginConversation

Review Request #2645 — Created Oct. 10, 2023 and submitted Oct. 10, 2023, 8:03 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~2640~~

Reviewers

Groups

pidgin

People

Description

This allows you to get a tooltip for the timestamp and the edited label that
displays the time in the locale's default format. The edited label was tested
by forcing the demo protocol plugin to mark messages as edited.

Testing Done

Sent a bunch of messages with the echo bot and verified the timestamp tooltip on IRCv3 as well.

Commits

Summary	ID
Add tooltips to timestamps in PidginConversation This allows you to get a tooltip for the timestamp and the edited label that displays the time in the locale's default format. The edited label was tested by forcing the demo protocol plugin to mark messages as edited.	72ead6a7ff206000d1e420dcf6aa85a30749052e

Issues

Description	From	Last Updated
... its return value should be returned from that handler.	QuLogic	Oct. 10, 2023, 8:01 a.m.
* -> *	QuLogic	Oct. 10, 2023, 7:59 a.m.
* -> *	QuLogic	Oct. 10, 2023, 7:59 a.m.

Change Summary:

rebased

Commits:

	Summary	ID
	Add tooltips to timestamps in PidginConversation This allows you to get a tooltip for the timestamp and the edited label that displays the time in the locale's default format. The edited label was tested by forcing the demo protocol plugin to mark messages as edited.	5000ba25e25cdebf37883292e626551c0677f19b
	Add tooltips to timestamps in PidginConversation This allows you to get a tooltip for the timestamp and the edited label that displays the time in the locale's default format. The edited label was tested by forcing the demo protocol plugin to mark messages as edited.	149864759f08067431fdfe9be67246a8fb0e4437

Diff:

Revision 2 (+176 -2)

Show changes

	pidgin/pidginconversation.c
	pidgin/resources/Conversations/message.ui

pidgin/pidginconversation.c (Diff revision 2)
Show all issues
```
... its return value should be returned from that handler.
```
1. QuLogic Oct. 10, 2023, 7:59 a.m.
  Missed the 'its' still.
pidgin/pidginconversation.c (Diff revision 2)
Show all issues
```
* -> *
```
pidgin/pidginconversation.c (Diff revision 2)
Show all issues
```
* -> *
```

Change Summary:

address issues

Commits:

	Summary	ID
	Add tooltips to timestamps in PidginConversation This allows you to get a tooltip for the timestamp and the edited label that displays the time in the locale's default format. The edited label was tested by forcing the demo protocol plugin to mark messages as edited.	149864759f08067431fdfe9be67246a8fb0e4437
	Add tooltips to timestamps in PidginConversation This allows you to get a tooltip for the timestamp and the edited label that displays the time in the locale's default format. The edited label was tested by forcing the demo protocol plugin to mark messages as edited.	d8307f8f55ab67b38e846c0398fee2e1d351e008

Diff:

Revision 3 (+176 -2)

Show changes

	pidgin/pidginconversation.c
	pidgin/resources/Conversations/message.ui

Change Summary:

its

Commits:

	Summary	ID
	Add tooltips to timestamps in PidginConversation This allows you to get a tooltip for the timestamp and the edited label that displays the time in the locale's default format. The edited label was tested by forcing the demo protocol plugin to mark messages as edited.	d8307f8f55ab67b38e846c0398fee2e1d351e008
	Add tooltips to timestamps in PidginConversation This allows you to get a tooltip for the timestamp and the edited label that displays the time in the locale's default format. The edited label was tested by forcing the demo protocol plugin to mark messages as edited.	72ead6a7ff206000d1e420dcf6aa85a30749052e

Diff:

Revision 4 (+176 -2)

Show changes

	pidgin/pidginconversation.c
	pidgin/resources/Conversations/message.ui

Ship it!

```
Ship It!
```

Review Board 6.0.2

Add tooltips to timestamps in PidginConversation

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)

pidgin/pidginconversation.c (Diff revision 2)

pidgin/pidginconversation.c (Diff revision 2)

pidgin/pidginconversation.c (Diff revision 2)