Summary

Add an edited property to PurpleMessage

Review Request #2640 — Created Oct. 8, 2023 and submitted Oct. 10, 2023, 6:22 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

2645

Reviewers

Groups

pidgin

People

Description

Add an edited property to PurpleMessage

Testing Done

Ran the unit tests under valgrind.

Commits

Summary	ID
Add an edited property to PurpleMessage	b4a8913fceb67ad05778245699131e766659079c

Issues

Description	From	Last Updated
This seems good, but I wonder if want this to be a timestamp?	QuLogic	Oct. 10, 2023, 6:16 a.m.
There is no edited struct member to change, so I guess this just means 'notify on edited'.	QuLogic	Oct. 10, 2023, 6:21 a.m.

Show all issues

This seems good, but I wonder if want this to be a timestamp?

Change Summary:

rebased and reworked to use have an edited-at property that edited is based off of.

Commits:

	Summary	ID
	Add an edited property to PurpleMessage	31154084bd158f1f29a8edd934064c891fa152db
	Add an edited property to PurpleMessage	654133d4d983decc59c24a7057e0695d31fbe72a

Diff:

Revision 2 (+514 -8)

Show changes

	libpurple/purplemessage.h
	libpurple/purplemessage.c
	libpurple/tests/test_message.c

Ship it!

```
Ship It!
```

libpurple/purplemessage.c (Diff revision 2)

Show all issues

There is no edited struct member to change, so I guess this just means 'notify on edited'.

Change Summary:

deleted the comments in question as they don't make sense anymore.

Commits:

	Summary	ID
	Add an edited property to PurpleMessage	654133d4d983decc59c24a7057e0695d31fbe72a
	Add an edited property to PurpleMessage	b4a8913fceb67ad05778245699131e766659079c

Diff:

Revision 3 (+504 -18)

Show changes

	libpurple/purplemessage.h
	libpurple/purplemessage.c
	libpurple/tests/test_message.c

Review Board 6.0.2

Add an edited property to PurpleMessage

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)