Summary

Add the ability to join channels to PurpleProtocolConversation

Review Request #2619 — Created Sept. 14, 2023 and submitted Oct. 3, 2023, 5:03 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~2616~~

Groups

People

Description

Add the ability to join channels to PurpleProtocolConversation

Testing Done

Ran the unit tests under valgrind.

Commits

Summary	ID
Add the ability to join channels to PurpleProtocolConversation	1d8be92ed8f7f86bb2851482f224183c97894212

Issues

Description	From	Last Updated
The return type is gboolean so I guess this should say %FALSE and not %NULL.	ivanhoe	Sept. 30, 2023, 7:42 a.m.

Change Summary:: Fix typo
Testing Done:: ~
Rand the unit tests under valgrind.
~
Ran the unit tests under valgrind.

Change Summary:

rebased

Commits:

	Summary	ID
	Add the ability to join channels to PurpleProtocolConversation	5a61515f7138b091cb49eea737b719afcb70f992
	Add the ability to join channels to PurpleProtocolConversation	fd33dfe0887450a91b6361d1ec6937e24df3d513

Diff:

Revision 2 (+784 -10)

	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/test_protocol_conversation.c

libpurple/purpleprotocolconversation.h (Diff revision 2)
The issue has been resolved. Show all issues
```
The return type is gboolean so I guess this should say %FALSE and not %NULL.
```

Change Summary:

rebased and addressed issues

Commits:

	Summary	ID
	Add the ability to join channels to PurpleProtocolConversation	fd33dfe0887450a91b6361d1ec6937e24df3d513
	Add the ability to join channels to PurpleProtocolConversation	1d8be92ed8f7f86bb2851482f224183c97894212

Diff:

Revision 3 (+784 -10)

	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/test_protocol_conversation.c

Ship it!

~		Rand the unit tests under valgrind.
	~	Ran the unit tests under valgrind.