Create PurpleChannelJoinDetails to replace the components for join chats

Review Request #2616 — Created Sept. 12, 2023 and submitted Sept. 19, 2023, 6:41 a.m.

Information
Owner:	grim
Repository:	pidgin/pidgin
Branch:	default
Bugs:
Depends On:
Blocks:	2619
Reviewers
Groups:	pidgin
People:

Description

This will be used be a new PurpleProtocolConversation vfunc in the near future
which the ui can request to get information about how to join a chat for a
protocol.

Testing Done

Ran the unit tests under valgrind and verified the docs built with no new warnings.

Commits

Summary
	Create PurpleChannelJoinDetails to replace the components for join chats

Screenshots

Issues

Description	From	Last Updated
I think this transfer none isn't needed since it's const char *?	QuLogic	Sept. 19, 2023, 6:34 a.m.
channel-specific	QuLogic	Sept. 19, 2023, 6:35 a.m.
s/specific/specified/	QuLogic	Sept. 19, 2023, 6:35 a.m.
s/it's/its/	QuLogic	Sept. 19, 2023, 6:35 a.m.
channel-specific	QuLogic	Sept. 19, 2023, 6:35 a.m.
channel-specific	QuLogic	Sept. 19, 2023, 6:35 a.m.
channel-specific	QuLogic	Sept. 19, 2023, 6:35 a.m.
channel-specific	QuLogic	Sept. 19, 2023, 6:35 a.m.

Change Summary:

rebased

Commits:

	Summary
-		Create PurpleChannelJoinDetails to replace the components for join chats
+		Create PurpleChannelJoinDetails to replace the components for join chats

Diff:

Revision 2 (+1254)

Show changes

	libpurple/meson.build
	libpurple/purplechanneljoindetails.h
	libpurple/purplechanneljoindetails.c
	libpurple/tests/meson.build
	libpurple/tests/test_channel_join_details.c

libpurple/purplechanneljoindetails.h (Diff revision 2)

Show all issues

I think this transfer none isn't needed since it's const char *?

libpurple/purplechanneljoindetails.h (Diff revision 2)
Show all issues
```
channel-specific
```
libpurple/purplechanneljoindetails.h (Diff revision 2)
Show all issues
```
s/specific/specified/
```
libpurple/purplechanneljoindetails.h (Diff revision 2)
Show all issues
```
s/it's/its/
```
libpurple/purplechanneljoindetails.c (Diff revision 2)
Show all issues
```
channel-specific
```
libpurple/purplechanneljoindetails.c (Diff revision 2)
Show all issues
```
channel-specific
```
libpurple/purplechanneljoindetails.c (Diff revision 2)
Show all issues
```
channel-specific
```
libpurple/purplechanneljoindetails.c (Diff revision 2)
Show all issues
```
channel-specific
```

Change Summary:

rebased and address issues.

Commits:

	Summary
-		Create PurpleChannelJoinDetails to replace the components for join chats
+		Create PurpleChannelJoinDetails to replace the components for join chats

Diff:

Revision 3 (+1254)

Show changes

	libpurple/meson.build
	libpurple/purplechanneljoindetails.h
	libpurple/purplechanneljoindetails.c
	libpurple/tests/meson.build
	libpurple/tests/test_channel_join_details.c

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 5.0.6

Create PurpleChannelJoinDetails to replace the components for join chats

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)