Create PurpleChannelJoinDetails to replace the components for join chats

Review Request #2616 — Created Sept. 12, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

This will be used be a new PurpleProtocolConversation vfunc in the near future
which the ui can request to get information about how to join a chat for a
protocol.

Ran the unit tests under valgrind and verified the docs built with no new warnings.

Summary ID
Create PurpleChannelJoinDetails to replace the components for join chats
This will be used be a new PurpleProtocolConversation vfunc in the near future which the ui can request to get information about how to join a chat for a protocol.
a0d2da7d92a4c724648b0b5094f13a486d221427
Description From Last Updated

I think this transfer none isn't needed since it's const char *?

QuLogicQuLogic

channel-specific

QuLogicQuLogic

s/specific/specified/

QuLogicQuLogic

s/it's/its/

QuLogicQuLogic

channel-specific

QuLogicQuLogic

channel-specific

QuLogicQuLogic

channel-specific

QuLogicQuLogic

channel-specific

QuLogicQuLogic
grim
QuLogic
  1. 
      
  2. libpurple/purplechanneljoindetails.h (Diff revision 2)
     
     
    Show all issues

    I think this transfer none isn't needed since it's const char *?

  3. libpurple/purplechanneljoindetails.h (Diff revision 2)
     
     
     
     
    Show all issues

    channel-specific

  4. libpurple/purplechanneljoindetails.h (Diff revision 2)
     
     
    Show all issues

    s/specific/specified/

  5. libpurple/purplechanneljoindetails.h (Diff revision 2)
     
     
    Show all issues

    s/it's/its/

  6. libpurple/purplechanneljoindetails.c (Diff revision 2)
     
     
    Show all issues

    channel-specific

  7. libpurple/purplechanneljoindetails.c (Diff revision 2)
     
     
    Show all issues

    channel-specific

  8. libpurple/purplechanneljoindetails.c (Diff revision 2)
     
     
    Show all issues

    channel-specific

  9. libpurple/purplechanneljoindetails.c (Diff revision 2)
     
     
    Show all issues

    channel-specific

  10. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed