Summary

Create PurpleChannelJoinDetails to replace the components for join chats

Review Request #2616 — Created Sept. 12, 2023 and submitted Sept. 19, 2023, 1:41 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

2619

Reviewers

Groups

pidgin

People

Description

This will be used be a new PurpleProtocolConversation vfunc in the near future
which the ui can request to get information about how to join a chat for a
protocol.

Testing Done

Ran the unit tests under valgrind and verified the docs built with no new warnings.

Commits

Summary	ID
Create PurpleChannelJoinDetails to replace the components for join chats This will be used be a new PurpleProtocolConversation vfunc in the near future which the ui can request to get information about how to join a chat for a protocol.	a0d2da7d92a4c724648b0b5094f13a486d221427

Issues

Description	From	Last Updated
I think this transfer none isn't needed since it's const char *?	QuLogic	Sept. 19, 2023, 1:34 a.m.
channel-specific	QuLogic	Sept. 19, 2023, 1:35 a.m.
s/specific/specified/	QuLogic	Sept. 19, 2023, 1:35 a.m.
s/it's/its/	QuLogic	Sept. 19, 2023, 1:35 a.m.
channel-specific	QuLogic	Sept. 19, 2023, 1:35 a.m.
channel-specific	QuLogic	Sept. 19, 2023, 1:35 a.m.
channel-specific	QuLogic	Sept. 19, 2023, 1:35 a.m.
channel-specific	QuLogic	Sept. 19, 2023, 1:35 a.m.

Change Summary:

rebased

Commits:

	Summary	ID
	Create PurpleChannelJoinDetails to replace the components for join chats This will be used be a new PurpleProtocolConversation vfunc in the near future which the ui can request to get information about how to join a chat for a protocol.	a6a5e674b8bee4330448aa4727511d9188ea7de8
	Create PurpleChannelJoinDetails to replace the components for join chats This will be used be a new PurpleProtocolConversation vfunc in the near future which the ui can request to get information about how to join a chat for a protocol.	29028611fdee099d2f42903d9aa56c19a4e4777e

Diff:

Revision 2 (+1254)

Show changes

	libpurple/meson.build
	libpurple/purplechanneljoindetails.h
	libpurple/purplechanneljoindetails.c
	libpurple/tests/meson.build
	libpurple/tests/test_channel_join_details.c

libpurple/purplechanneljoindetails.h (Diff revision 2)
The issue has been resolved. Show all issues
```
I think this transfer none isn't needed since it's const char *?
```
libpurple/purplechanneljoindetails.h (Diff revision 2)
The issue has been resolved. Show all issues
```
channel-specific
```
libpurple/purplechanneljoindetails.h (Diff revision 2)
The issue has been resolved. Show all issues
```
s/specific/specified/
```
libpurple/purplechanneljoindetails.h (Diff revision 2)
The issue has been resolved. Show all issues
```
s/it's/its/
```
libpurple/purplechanneljoindetails.c (Diff revision 2)
The issue has been resolved. Show all issues
```
channel-specific
```
libpurple/purplechanneljoindetails.c (Diff revision 2)
The issue has been resolved. Show all issues
```
channel-specific
```
libpurple/purplechanneljoindetails.c (Diff revision 2)
The issue has been resolved. Show all issues
```
channel-specific
```
libpurple/purplechanneljoindetails.c (Diff revision 2)
The issue has been resolved. Show all issues
```
channel-specific
```

Change Summary:

rebased and address issues.

Commits:

	Summary	ID
	Create PurpleChannelJoinDetails to replace the components for join chats This will be used be a new PurpleProtocolConversation vfunc in the near future which the ui can request to get information about how to join a chat for a protocol.	29028611fdee099d2f42903d9aa56c19a4e4777e
	Create PurpleChannelJoinDetails to replace the components for join chats This will be used be a new PurpleProtocolConversation vfunc in the near future which the ui can request to get information about how to join a chat for a protocol.	a0d2da7d92a4c724648b0b5094f13a486d221427

Diff:

Revision 3 (+1254)

Show changes

	libpurple/meson.build
	libpurple/purplechanneljoindetails.h
	libpurple/purplechanneljoindetails.c
	libpurple/tests/meson.build
	libpurple/tests/test_channel_join_details.c

Ship it!

```
Ship It!
```

Status:: Completed