Use PurpleProtocolConversation if it's available when sending a message.

Review Request #2614 — Created Sept. 11, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

Eventually PurpleConversation.send will be going away, but for now we'll use
the PurpleProtocolConversation interface if it is available to send messages
rather than the PurpleProtocolChat and PurpleProtocolIM interfaces.

Send message with the IRCv3 protocol updates from /r/2615 without issue. Also sent messages via xmpp to an im and a chat.

Summary ID
Use PurpleProtocolConversation if it's available when sending a message.
Eventually PurpleConversation.send will be going away, but for now we'll use the PurpleProtocolConversation interface if it is available to send messages rather than the PurpleProtocolChat and PurpleProtocolIM interfaces.
63ac8347baac697a1c71bb56c5d2b8435f63b593
Description From Last Updated

No timestamp? Or is there a reason not to use purple_message_new_outgoing like the other cases?

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/purpleconversation.c (Diff revision 1)
     
     
     
     
     
     
     
    Show all issues

    No timestamp? Or is there a reason not to use purple_message_new_outgoing like the other cases?

    1. I've been avoiding purple_message_new_outgoing because I thought it did some weird stuff, but it looks like most of that is gone or I just don't remember, minus the recipient stuff that's still required.

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed