Summary

Use PurpleProtocolConversation if it's available when sending a message.

Review Request #2614 — Created Sept. 12, 2023 and submitted Sept. 12, 2023, 8:11 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~2611~~

Blocks

2615

Reviewers

Groups

pidgin

People

Description

Eventually PurpleConversation.send will be going away, but for now we'll use
the PurpleProtocolConversation interface if it is available to send messages
rather than the PurpleProtocolChat and PurpleProtocolIM interfaces.

Testing Done

Send message with the IRCv3 protocol updates from /r/2615 without issue. Also sent messages via xmpp to an im and a chat.

Commits

Summary	ID
Use PurpleProtocolConversation if it's available when sending a message. Eventually PurpleConversation.send will be going away, but for now we'll use the PurpleProtocolConversation interface if it is available to send messages rather than the PurpleProtocolChat and PurpleProtocolIM interfaces.	63ac8347baac697a1c71bb56c5d2b8435f63b593

Issues

Description	From	Last Updated
No timestamp? Or is there a reason not to use purple_message_new_outgoing like the other cases?	QuLogic	Sept. 12, 2023, 6:57 a.m.

libpurple/purpleconversation.c (Diff revision 1)

Show all issues

No timestamp? Or is there a reason not to use purple_message_new_outgoing like the other cases?

grim Sept. 12, 2023, 5:47 a.m.

I've been avoiding purple_message_new_outgoing because I thought it did some weird stuff, but it looks like most of that is gone or I just don't remember, minus the recipient stuff that's still required.

Change Summary:

use purple_message_new_outgoing. Tested by sending some dm's on ircv3.

Commits:

	Summary	ID
	Use PurpleProtocolConversation if it's available when sending a message. Eventually PurpleConversation.send will be going away, but for now we'll use the PurpleProtocolConversation interface if it is available to send messages rather than the PurpleProtocolChat and PurpleProtocolIM interfaces.	b5832535a17b2cdd320688a1260e6ccdfe6ee329
	Use PurpleProtocolConversation if it's available when sending a message. Eventually PurpleConversation.send will be going away, but for now we'll use the PurpleProtocolConversation interface if it is available to send messages rather than the PurpleProtocolChat and PurpleProtocolIM interfaces.	63ac8347baac697a1c71bb56c5d2b8435f63b593

Diff:

Revision 2 (+80 -2)

Show changes

libpurple/purpleconversation.c

Ship it!

```
Ship It!
```

Review Board 6.0.2