Summary

Create the initial PurpleProtocolConversation

Review Request #2611 — Created Sept. 10, 2023 and submitted Sept. 12, 2023, 6:47 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

2613, 2614

Reviewers

Groups

pidgin

People

Description

This interface will handle all protocol interactions for conversations now that
we are flattening their object hierarchy.

Testing Done

Ran the unit tests under valgrind.

Commits

Summary	ID
Create the initial PurpleProtocolConversation This interface will handle all protocol interactions for conversations now that we are flattening their object hierarchy.	c24f21fd957823e1095137744e32120bafd07946

Change Summary:

Fix some comments

Commits:

	Summary	ID
	Create the initial PurpleProtocolConversation This interface will handle all protocol interactions for conversations now that we are flattening their object hierarchy.	0886bc6bd3f261f8d6cb81d183eddb85a7067f93
	Create the initial PurpleProtocolConversation This interface will handle all protocol interactions for conversations now that we are flattening their object hierarchy.	ac8bd1ce94a74563c19e893251d47a6489a6bd16

Diff:

Revision 2 (+1092)

Show changes

	libpurple/meson.build
	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/meson.build
	libpurple/tests/test_protocol_conversation.c

Change Summary:

fix an indentation issue

Commits:

	Summary	ID
	Create the initial PurpleProtocolConversation This interface will handle all protocol interactions for conversations now that we are flattening their object hierarchy.	ac8bd1ce94a74563c19e893251d47a6489a6bd16
	Create the initial PurpleProtocolConversation This interface will handle all protocol interactions for conversations now that we are flattening their object hierarchy.	f1706ebf654ee2bedec3c425bd11cd43bb321ef3

Diff:

Revision 3 (+1092)

Show changes

	libpurple/meson.build
	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/meson.build
	libpurple/tests/test_protocol_conversation.c

Change Summary:

use g_test_add_data_func to avoid a bunch of duplication.

Commits:

	Summary	ID
	Create the initial PurpleProtocolConversation This interface will handle all protocol interactions for conversations now that we are flattening their object hierarchy.	f1706ebf654ee2bedec3c425bd11cd43bb321ef3
	Create the initial PurpleProtocolConversation This interface will handle all protocol interactions for conversations now that we are flattening their object hierarchy.	c24f21fd957823e1095137744e32120bafd07946

Diff:

Revision 4 (+1056)

Show changes

	libpurple/meson.build
	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/meson.build
	libpurple/tests/test_protocol_conversation.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Create the initial PurpleProtocolConversation

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)