Commits: |
|
||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+334 -10) |
Add support to fetch username from LDAP
Review Request #2450 — Created May 2, 2023 and submitted
Add support to fetch username from LDAP
| Summary | ID | Author |
|---|---|---|
| 3dd83b4de959b9ad424810c604abe0dcf5571d37 | Andre Klitzing |
| Description | From | Last Updated |
|---|---|---|
|
While this look okay overall, I'm on the fence if hgkeeper should be supporting stuff like ldap and other IdP's … |
 grim
|
|
|
Looks good, just waiting on 2449 to move forward with this. |
grim
|
|
|
since this is in the access package this should probably be namespaced to something a bit more specific than just … |
grim
|
|
|
s/pf/for the/ |
grim
|
Summary: |
|
||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||
Commits: |
|
||||||||||
Diff: |
Revision 3 (+334 -10) |
Commits: |
|
||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+334 -10) |
Commits: |
|
||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+320 -10) |
Commits: |
|
||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 6 (+302 -10) |
-
-
While this look okay overall, I'm on the fence if hgkeeper should be supporting stuff like ldap and other IdP's directly and instead wondering if it would make more sense to run a command like the ssh
AuthorizedKeysCommandbecause then we just have one interface and people can adapt to whatever their situation is without code changes. -
access/ldap.go (Diff revision 6) since this is in the access package this should probably be namespaced to something a bit more specific than just
config. -
Commits: |
|
||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 7 (+302 -10) |