Add support to fetch username from LDAP

Review Request #2450 — Created May 2, 2023 and updated

aklitzing@gmail.com
grim/hgkeeper
default
2449
grim

Add support to fetch username from LDAP



Summary Author
Add support to fetch username from LDAP
Andre Klitzing
Description From Last Updated

While this look okay overall, I'm on the fence if hgkeeper should be supporting stuff like ldap and other IdP's …

grimgrim

since this is in the access package this should probably be namespaced to something a bit more specific than just …

grimgrim

s/pf/for the/

grimgrim
aklitzing@gmail.com
aklitzing@gmail.com
aklitzing@gmail.com
aklitzing@gmail.com
aklitzing@gmail.com
grim
  1. 
      
  2. While this look okay overall, I'm on the fence if hgkeeper should be supporting stuff like ldap and other IdP's directly and instead wondering if it would make more sense to run a command like the ssh AuthorizedKeysCommand because then we just have one interface and people can adapt to whatever their situation is without code changes.

    1. Well, I like the idea to have an easy but powerful mercurial hosting without any admin-ui. If we introduce a special ExternalUsernameCommand anyone needs to setup ldap and other stuff by itself.

      I would like to introduce ExternalUsernameCommand but we could provide another hgkeeper command like "hgkeeper ldap". So someone can add "hgkeeper ldap" as ExternalUsernameCommand. So we have both.

    2. Mh, but that wouldn't allow persistent connections because the binary will be closed anytime. :-/

  3. access/ldap.go (Diff revision 6)
     
     

    since this is in the access package this should probably be namespaced to something a bit more specific than just config.

  4. docs/docs/ldap.md (Diff revision 6)
     
     

    s/pf/for the/

  5. 
      
aklitzing@gmail.com
Review request changed

Commits:

Summary Author
-
Add support to fetch username from LDAP
Andre Klitzing
+
Add support to fetch username from LDAP
Andre Klitzing

Diff:

Revision 7 (+302 -10)

Show changes

Loading...