Refactor to use key directly instead of fingerprint

Review Request #2449 — Created April 29, 2023 and updated

Information
aklitzing@gmail.com
grim/hgkeeper
default
2450
Reviewers
grim 
OpenSSH can provide the type and key with "%t %k". So we do not need
to match it with fingerprints.

This simplifies key handling a lot and allows to search for requested
pubkey in later changes.




 












 

  
  





 

   

   

   

 
 
  

    Summary

   Author

  

 
 

  


   

    
     
    

   

   
Refactor to use key instead of fingerprint directly


   Andre Klitzing

  


 






 




 

 






 
 
 

  

   

    
   

   
    
    
  • 
     
    
    • 
    
  • 
     
    
    • 
    
  • 
     
    
    • 
    
  • 
     
    
    • 
    
  • 
     
    
    • 
   

  

  

   
    

     Description
     From
     Last Updated
    

   
   



    

     
      
      
overall this looks good but it totally breaks existing ssh setups and we should avoid that.

     		
     
      grimgrim
     
     
      
     
    




    

     
      
      
some people use rsa4096 keys and that's a lot to output in a log message so it probably makes sense …

     		
     
      grimgrim
     
     
      
     
    


   
  

 












  

 








 














 



 

  

   




aklitzing@gmail.com




   

   

  

 



 















 



 

  

   




aklitzing@gmail.com




   

   

  

 



 















 





 

  

   




grim




   

   







  

 



 

  


   

   

    
 
grim


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    overall this looks good but it totally breaks existing ssh setups and we should avoid that.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Yeah, I know. But shouldn't be a new release with big "release notes: breaking change!" enough? It is just %f to "%t %k"
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Major release should be allowed to break old stuff. Mabye it is time to remove "site hgrc", too?
      
 
      

      3. 


 
    


    

 
    

    3. 















  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      ssh/server.go
      


       (Diff revision 2)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    some people use rsa4096 keys and that's a lot to output in a log message so it probably makes sense to use the finger print here.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




aklitzing@gmail.com




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  











 



  

   
Commits:

   
    



 

  
    

    

    

    

  
  
   

    
    Summary

    Author
   


  
  

   

    -

     

      
       
      

     

    
Refactor to use key instead of fingerprint directly


    Andre Klitzing

   



   

    +

     

      
       
      

     

     
Refactor to use key instead of fingerprint directly


    Andre Klitzing

   


  
 




   		
  




  

   
Diff:

   
    
 Revision 3 (+52 -114)
Show changes
 
    access/users.go 
    authorized_keys/command.go 
    docs/includes/ondemand/openssh.md 
    docs/includes/reverseproxy/openssh.md 
    examples/openssh/hgkeeper.conf 
    http/authorized_keys.go 
    ssh/server.go 
 

   		
  



 










  

 









     

    

   

  

  

   
   Loading...