Add support to fetch username from LDAP

Review Request #2450 — Created May 2, 2023 and submitted

Information

grim/hgkeeper
default

Reviewers

Add support to fetch username from LDAP


 
Summary ID Author
Add support to fetch username from LDAP
3dd83b4de959b9ad424810c604abe0dcf5571d37 Andre Klitzing
Description From Last Updated

While this look okay overall, I'm on the fence if hgkeeper should be supporting stuff like ldap and other IdP's …

grimgrim

Looks good, just waiting on 2449 to move forward with this.

grimgrim

since this is in the access package this should probably be namespaced to something a bit more specific than just …

grimgrim

s/pf/for the/

grimgrim
aklitzing@gmail.com
aklitzing@gmail.com
aklitzing@gmail.com
aklitzing@gmail.com
aklitzing@gmail.com
grim
  1. 
      
  2. Show all issues

    While this look okay overall, I'm on the fence if hgkeeper should be supporting stuff like ldap and other IdP's directly and instead wondering if it would make more sense to run a command like the ssh AuthorizedKeysCommand because then we just have one interface and people can adapt to whatever their situation is without code changes.

    1. Well, I like the idea to have an easy but powerful mercurial hosting without any admin-ui. If we introduce a special ExternalUsernameCommand anyone needs to setup ldap and other stuff by itself.

      I would like to introduce ExternalUsernameCommand but we could provide another hgkeeper command like "hgkeeper ldap". So someone can add "hgkeeper ldap" as ExternalUsernameCommand. So we have both.

    2. Mh, but that wouldn't allow persistent connections because the binary will be closed anytime. :-/

  3. access/ldap.go (Diff revision 6)
     
     
    Show all issues

    since this is in the access package this should probably be namespaced to something a bit more specific than just config.

  4. docs/docs/ldap.md (Diff revision 6)
     
     
    Show all issues

    s/pf/for the/

  5. 
      
aklitzing@gmail.com
grim
  1. 
      
  2. Show all issues

    Looks good, just waiting on 2449 to move forward with this.

  3. 
      
grim
  1. Ship It!
  2. Thank you for your work and your patience!

  3. 
      
grim
Review request changed
Status:
Completed