Summary

Simplify the buffers by making everything work on a TalkatuBuffer

Review Request #2224 — Created Jan. 31, 2023 and submitted Feb. 23, 2023, 6:23 a.m.

Information

Owner

grim

Repository

talkatu/talkatu

Branch

default

Bugs

Depends On

~~2213~~

Reviewers

Groups

pidgin

People

Description

The only things the content type specific buffers were doing now as defining
which formatting actions would be enabled. So we now created an flags and a
property on TalkatuActionGroup to fix that. By doing so, we are able to get
rid of TalkatuHTMLBuffer, TalkatuMarkdownBuffer, and TalkatuWholeBuffer.

Testing Done

Ran the demo, tested all the buffers as well as the insert html and mark down actions.

Commits

Summary	ID
Simplify the buffers by making everything work on a TalkatuBuffer The only things the content type specific buffers were doing now as defining which formatting actions would be enabled. So we now created an flags and a property on TalkatuActionGroup to fix that. By doing so, we are able to get rid of TalkatuHTMLBuffer, TalkatuMarkdownBuffer, and TalkatuWholeBuffer.	feaa3f7b8dd3a6291e4af02f48fea97242c8d021

Issues

Description	From	Last Updated
It's just name in the function header.	ivanhoe	Feb. 23, 2023, 6:08 a.m.
s/not enable/to enable	ivanhoe	Feb. 23, 2023, 6:08 a.m.
*its	ivanhoe	Feb. 23, 2023, 6:08 a.m.
s/action_name/name	ivanhoe	Feb. 23, 2023, 6:19 a.m.
Should there be a notification about the changed buffer?	ivanhoe	Feb. 23, 2023, 6:08 a.m.
*currently	ivanhoe	Feb. 23, 2023, 6:09 a.m.
*currently	ivanhoe	Feb. 23, 2023, 6:09 a.m.
It still says TalkatuMarkdownBuffer in the comment.	ivanhoe	Feb. 23, 2023, 6:19 a.m.
Shouldn't this documentation go into the header, since it's public API?	ivanhoe	Feb. 23, 2023, 6:10 a.m.
*TalkatuBuffer	ivanhoe	Feb. 23, 2023, 6:10 a.m.

Depends On:

+	~~2213 - Backout the blueprint compiler stuff~~

Change Summary:

rebased

Commits:

	Summary	ID
	Simplify the buffers by making everything work on a TalkatuBuffer The only things the content type specific buffers were doing now as defining which formatting actions would be enabled. So we now created an flags and a property on TalkatuActionGroup to fix that. By doing so, we are able to get rid of TalkatuHTMLBuffer, TalkatuMarkdownBuffer, and TalkatuWholeBuffer.	b663e39cbe99560952a674645482e2ec1731d151
	Simplify the buffers by making everything work on a TalkatuBuffer The only things the content type specific buffers were doing now as defining which formatting actions would be enabled. So we now created an flags and a property on TalkatuActionGroup to fix that. By doing so, we are able to get rid of TalkatuHTMLBuffer, TalkatuMarkdownBuffer, and TalkatuWholeBuffer.	df5c478b12de9cd16a694ce5fda34dfe5ef39aab

Diff:

Revision 2 (+810 -1188)

Show changes

	meson.build
	demo/talkatudemowindow.c
	demo/data/demo.ui
	talkatu/meson.build
	talkatu/talkatuactiongroup.h
	talkatu/talkatuactiongroup.c
	talkatu/talkatubuffer.h
	talkatu/talkatubuffer.c
	9 more

talkatu/talkatuactiongroup.c (Diff revision 2)
Show all issues
```
It's just name in the function header.
```
talkatu/talkatuactiongroup.c (Diff revision 2)
Show all issues
```
s/not enable/to enable
```
talkatu/talkatuactiongroup.c (Diff revision 2)
Show all issues
```
*its
```

talkatu/talkatuactiongroup.c (Diff revision 2)

Show all issues

Should there be a notification about the changed buffer?

talkatu/talkatuactiongroup.c (Diff revision 2)
Show all issues
```
*currently
```
talkatu/talkatubuffer.c (Diff revision 2)
Show all issues
```
*currently
```

talkatu/talkatumarkdown.c (Diff revision 2)

Show all issues

Shouldn't this documentation go into the header, since it's public API?

grim Feb. 23, 2023, 4:46 a.m.

The documentation tools don't care. And this is kind of mixed among our tools.

The pidgin repo does it in the header file because doxygen required it long ago and there's debate about it being useful in the header files.

In the projects I started it all goes into the source files because not many people would read the installed header files when they could just install the documentation that's much easier to work with. But the debate was never settled so it differs across the projects.

talkatu/talkatumarkdown.c (Diff revision 2)
Show all issues
```
*TalkatuBuffer
```

Change Summary:

addressed issues.

Commits:

	Summary	ID
	Simplify the buffers by making everything work on a TalkatuBuffer The only things the content type specific buffers were doing now as defining which formatting actions would be enabled. So we now created an flags and a property on TalkatuActionGroup to fix that. By doing so, we are able to get rid of TalkatuHTMLBuffer, TalkatuMarkdownBuffer, and TalkatuWholeBuffer.	df5c478b12de9cd16a694ce5fda34dfe5ef39aab
	Simplify the buffers by making everything work on a TalkatuBuffer The only things the content type specific buffers were doing now as defining which formatting actions would be enabled. So we now created an flags and a property on TalkatuActionGroup to fix that. By doing so, we are able to get rid of TalkatuHTMLBuffer, TalkatuMarkdownBuffer, and TalkatuWholeBuffer.	346fe3a1470e162502b66758bd3e9d89ea9fed45

Diff:

Revision 3 (+814 -1188)

Show changes

	meson.build
	demo/talkatudemowindow.c
	demo/data/demo.ui
	talkatu/meson.build
	talkatu/talkatuactiongroup.h
	talkatu/talkatuactiongroup.c
	talkatu/talkatubuffer.h
	talkatu/talkatubuffer.c
	9 more

talkatu/talkatuactiongroup.c (Diff revisions 2 - 3)
Show all issues
```
s/action_name/name
```
talkatu/talkatumarkdown.c (Diff revisions 2 - 3)
Show all issues
```
It still says TalkatuMarkdownBuffer in the comment.
```

Change Summary:

fix additional issues

Commits:

	Summary	ID
	Simplify the buffers by making everything work on a TalkatuBuffer The only things the content type specific buffers were doing now as defining which formatting actions would be enabled. So we now created an flags and a property on TalkatuActionGroup to fix that. By doing so, we are able to get rid of TalkatuHTMLBuffer, TalkatuMarkdownBuffer, and TalkatuWholeBuffer.	346fe3a1470e162502b66758bd3e9d89ea9fed45
	Simplify the buffers by making everything work on a TalkatuBuffer The only things the content type specific buffers were doing now as defining which formatting actions would be enabled. So we now created an flags and a property on TalkatuActionGroup to fix that. By doing so, we are able to get rid of TalkatuHTMLBuffer, TalkatuMarkdownBuffer, and TalkatuWholeBuffer.	feaa3f7b8dd3a6291e4af02f48fea97242c8d021

Diff:

Revision 4 (+816 -1190)

Show changes

	meson.build
	demo/talkatudemowindow.c
	demo/data/demo.ui
	talkatu/meson.build
	talkatu/talkatuactiongroup.h
	talkatu/talkatuactiongroup.c
	talkatu/talkatubuffer.h
	talkatu/talkatubuffer.c
	9 more

Ship it!

```
Ship It!
```

Review Board 6.0.1

Simplify the buffers by making everything work on a TalkatuBuffer

Information

Reviewers

Depends On:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)