Simplify the buffers by making everything work on a TalkatuBuffer

Review Request #2224 — Created Jan. 31, 2023 and submitted

Information

talkatu/talkatu
default

Reviewers

The only things the content type specific buffers were doing now as defining
which formatting actions would be enabled. So we now created an flags and a
property on TalkatuActionGroup to fix that. By doing so, we are able to get
rid of TalkatuHTMLBuffer, TalkatuMarkdownBuffer, and TalkatuWholeBuffer.

Ran the demo, tested all the buffers as well as the insert html and mark down actions.

Summary ID
Simplify the buffers by making everything work on a TalkatuBuffer
The only things the content type specific buffers were doing now as defining which formatting actions would be enabled. So we now created an flags and a property on TalkatuActionGroup to fix that. By doing so, we are able to get rid of TalkatuHTMLBuffer, TalkatuMarkdownBuffer, and TalkatuWholeBuffer.
feaa3f7b8dd3a6291e4af02f48fea97242c8d021
Description From Last Updated

It's just name in the function header.

ivanhoeivanhoe

s/not enable/to enable

ivanhoeivanhoe

*its

ivanhoeivanhoe

s/action_name/name

ivanhoeivanhoe

Should there be a notification about the changed buffer?

ivanhoeivanhoe

*currently

ivanhoeivanhoe

*currently

ivanhoeivanhoe

It still says TalkatuMarkdownBuffer in the comment.

ivanhoeivanhoe

Shouldn't this documentation go into the header, since it's public API?

ivanhoeivanhoe

*TalkatuBuffer

ivanhoeivanhoe
grim
grim
ivanhoe
  1. 
      
  2. talkatu/talkatuactiongroup.c (Diff revision 2)
     
     

    It's just name in the function header.

  3. talkatu/talkatuactiongroup.c (Diff revision 2)
     
     

    s/not enable/to enable

  4. talkatu/talkatuactiongroup.c (Diff revision 2)
     
     
  5. talkatu/talkatuactiongroup.c (Diff revision 2)
     
     

    Should there be a notification about the changed buffer?

  6. talkatu/talkatuactiongroup.c (Diff revision 2)
     
     
    *currently
  7. talkatu/talkatubuffer.c (Diff revision 2)
     
     
    *currently
  8. talkatu/talkatumarkdown.c (Diff revision 2)
     
     

    Shouldn't this documentation go into the header, since it's public API?

    1. The documentation tools don't care. And this is kind of mixed among our tools.

      The pidgin repo does it in the header file because doxygen required it long ago and there's debate about it being useful in the header files.

      In the projects I started it all goes into the source files because not many people would read the installed header files when they could just install the documentation that's much easier to work with. But the debate was never settled so it differs across the projects.

  9. talkatu/talkatumarkdown.c (Diff revision 2)
     
     
    *TalkatuBuffer
  10. 
      
grim
ivanhoe
  1. 
      
  2. talkatu/talkatuactiongroup.c (Diff revisions 2 - 3)
     
     

    s/action_name/name

  3. talkatu/talkatumarkdown.c (Diff revisions 2 - 3)
     
     

    It still says TalkatuMarkdownBuffer in the comment.

  4. 
      
grim
ivanhoe
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...