Depends On: |
|
---|
Simplify the buffers by making everything work on a TalkatuBuffer
Review Request #2224 — Created Jan. 31, 2023 and submitted
The only things the content type specific buffers were doing now as defining which formatting actions would be enabled. So we now created an flags and a property on TalkatuActionGroup to fix that. By doing so, we are able to get rid of TalkatuHTMLBuffer, TalkatuMarkdownBuffer, and TalkatuWholeBuffer.
Ran the demo, tested all the buffers as well as the insert html and mark down actions.
Summary | ID |
---|---|
feaa3f7b8dd3a6291e4af02f48fea97242c8d021 |
Description | From | Last Updated |
---|---|---|
It's just name in the function header. |
![]() |
|
s/not enable/to enable |
![]() |
|
*its |
![]() |
|
s/action_name/name |
![]() |
|
Should there be a notification about the changed buffer? |
![]() |
|
*currently |
![]() |
|
*currently |
![]() |
|
It still says TalkatuMarkdownBuffer in the comment. |
![]() |
|
Shouldn't this documentation go into the header, since it's public API? |
![]() |
|
*TalkatuBuffer |
![]() |
Change Summary:
rebased
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+810 -1188) |

-
-
-
-
-
talkatu/talkatuactiongroup.c (Diff revision 2) Should there be a notification about the changed buffer?
-
-
-
talkatu/talkatumarkdown.c (Diff revision 2) Shouldn't this documentation go into the header, since it's public API?
-
Change Summary:
addressed issues.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+814 -1188) |

-
-
-
talkatu/talkatumarkdown.c (Diff revisions 2 - 3) It still says
TalkatuMarkdownBuffer
in the comment.
Change Summary:
fix additional issues
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+816 -1190) |