Summary

Backout the blueprint compiler stuff

Review Request #2213 — Created Jan. 25, 2023 and submitted Feb. 22, 2023, 3:34 a.m.

Information

Owner

grim

Repository

talkatu/talkatu

Branch

default

Bugs

Depends On

Blocks

2224

Reviewers

Groups

pidgin

People

Description

Turns out we just got used to the GTK Builder ui format, so the blueprint
compiler doesn't really do much for us.

This was a backout of 8c78e806f7c7 but then I put bindings in for the toolbar, send button, and edited buttons.

Testing Done

Built and ran the demo.

Commits

Summary	ID
Backout the blueprint compiler stuff Turns out we just got used to the GTK Builder ui format, so the blueprint compiler doesn't really do much for us.	1e83efbf3a9bbd28eb455f26aed1ca5ade55c1cd

Issues

Description	From	Last Updated
Maybe we can get rid of this now?	QuLogic	Feb. 22, 2023, 3:24 a.m.
Could be inlined.	QuLogic	Feb. 22, 2023, 3:25 a.m.
Can drop object and swapped?	QuLogic	Feb. 22, 2023, 3:25 a.m.
Can drop object and swapped?	QuLogic	Feb. 22, 2023, 3:25 a.m.
Can drop object and swapped?	QuLogic	Feb. 22, 2023, 3:25 a.m.
Can drop object and swapped?	QuLogic	Feb. 22, 2023, 3:25 a.m.
Can drop object and swapped?	QuLogic	Feb. 22, 2023, 3:25 a.m.
Can drop object and swapped?	QuLogic	Feb. 22, 2023, 3:25 a.m.
Can be dropped?	QuLogic	Feb. 22, 2023, 3:25 a.m.
Also can be dropped?	QuLogic	Feb. 22, 2023, 3:25 a.m.
Might not need these, since they weren't in the blueprint?	QuLogic	Feb. 22, 2023, 3:26 a.m.
Missing author-name-color: black	QuLogic	Feb. 22, 2023, 3:26 a.m.
Maybe can change 1 to return?	QuLogic	Feb. 22, 2023, 3:26 a.m.
Can drop object and swapped?	QuLogic	Feb. 22, 2023, 3:26 a.m.
Also can be dropped as it wasn't in the Blueprint?	QuLogic	Feb. 22, 2023, 3:26 a.m.
Can remove.	QuLogic	Feb. 22, 2023, 3:26 a.m.
We replaced this with Black/White.	QuLogic	Feb. 22, 2023, 3:27 a.m.
I don't see this file?	QuLogic	Feb. 22, 2023, 3:27 a.m.
I think you added the preset on purpose everywhere?	QuLogic	Feb. 22, 2023, 3:27 a.m.

demo/data/demo.ui (Diff revision 1)
Show all issues
```
Maybe we can get rid of this now?
```
demo/data/demo.ui (Diff revision 1)
Show all issues
```
Could be inlined.
```
demo/data/demo.ui (Diff revision 1)
Show all issues
```
Can drop object and swapped?
```
demo/data/demo.ui (Diff revision 1)
Show all issues
```
Can drop object and swapped?
```
demo/data/demo.ui (Diff revision 1)
Show all issues
```
Can drop object and swapped?
```
demo/data/demo.ui (Diff revision 1)
Show all issues
```
Can drop object and swapped?
```
demo/data/demo.ui (Diff revision 1)
Show all issues
```
Can drop object and swapped?
```
demo/data/demo.ui (Diff revision 1)
Show all issues
```
Can drop object and swapped?
```
demo/data/demo.ui (Diff revision 1)
Show all issues
```
Can be dropped?
```
demo/data/demo.ui (Diff revision 1)
Show all issues
```
Also can be dropped?
```

demo/data/demo.ui (Diff revision 1)

Show all issues

Might not need these, since they weren't in the blueprint?

demo/data/demo.ui (Diff revision 1)
Show all issues
```
Missing author-name-color: black
```
demo/data/demo.ui (Diff revision 1)
Show all issues
```
Maybe can change 1 to return?
```
demo/data/demo.ui (Diff revision 1)
Show all issues
```
Can drop object and swapped?
```

demo/data/demo.ui (Diff revision 1)

Show all issues

Also can be dropped as it wasn't in the Blueprint?

demo/data/demo.ui (Diff revision 1)
Show all issues
```
Can remove.
```

demo/data/demo.ui (Diff revision 1)

Show all issues

We replaced this with Black/White.

po/POTFILES (Diff revision 1)
Show all issues
```
I don't see this file?
```

po/meson.build (Diff revision 1)

Show all issues

I think you added the preset on purpose everywhere?

Commits:

	Summary	ID
	Backout the blueprint compiler stuff Turns out we just got used to the GTK Builder ui format, so the blueprint compiler doesn't really do much for us.	09bd954249ed6a54e7818458058641bab5b4133e
	Backout the blueprint compiler stuff Turns out we just got used to the GTK Builder ui format, so the blueprint compiler doesn't really do much for us.	1e83efbf3a9bbd28eb455f26aed1ca5ade55c1cd

Diff:

Revision 2 (+650 -588)

Show changes

	meson.build
	demo/meson.build
	demo/data/demo.ui
	demo/data/demo.blp
	demo/data/meson.build
	po/POTFILES
	subprojects/blueprint-compiler.wrap
	talkatu/meson.build

Ship it!

```
Ship It!
```

Review Board 6.0.2

Backout the blueprint compiler stuff

Information

Reviewers

Commits:

Diff:

Status: Closed (submitted)