- Change Summary:
-
rebased and updated for the changes in /r/1883
- Commits:
-
Summary ID 78655e0e5df000eead2c3ebb51111f80aaa18e93 3c51a5915e94b00735cb8f39b6ba79c16ae4aa23 - Diff:
-
Revision 2 (+1078 -8)
Add the ability to connect to IRCv3
Review Request #1880 — Created Oct. 3, 2022 and submitted
This does't login or do anything protocol wise, it is only establishing a TCP connection.
Connected to a local ergo instance over a plaintext connection and verified I saw the
Successfully connectedmessage in my output.
-
-
-
Instead of picking up the
PurpleConnectionfrom thePurpleAccount, that object could be passed in from the caller, which has it.Or this function could return aFurther reading shows that thegbooleanandGError, and the caller could be the one that handles thePurpleConnectionpart entirely, just like is done forpurple_ircv3_connection_valid.PurpleConnectionis passed on to the callbacks so we can't avoid it being in this function.
- Change Summary:
-
remove the cancellable from the
_initfunction - Commits:
-
Summary ID 3c51a5915e94b00735cb8f39b6ba79c16ae4aa23 0d87c4c0e54dbbfcfdcea054e2a6fe410bf2ae7d - Diff:
-
Revision 3 (+1076 -8)