Summary

Pass the PurpleProtocol objects to all methods of the class

Review Request #1883 — Created Oct. 4, 2022 and submitted Oct. 4, 2022, 2:56 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Previously login, close, and status_types weren't passed the PurpleProtocol
object, this fixes that so that these methods fit the normal pattern for
GObjects and it might handy in the future for other protocols.

Testing Done

Compiled

Commits

Summary	ID
Pass the PurpleProtocol objects to all methods of the class Previously login, close, and status_types weren't passed the PurpleProtocol object, this fixes that so that these methods fit the normal pattern for GObjects and it might handy in the future for other protocols.	004b32f92351c1a8e946c64de71857c4df5c083a

Issues

Description	From	Last Updated
Can you leave the G_GNUC_UNUSED out of the prototypes? Just for one less place to update later if it becomes …	QuLogic	Oct. 4, 2022, 2:53 a.m.
Same question.	QuLogic	Oct. 4, 2022, 2:53 a.m.

Ship it!

```
Ship It!
```

libpurple/protocols/irc/irc.c (Diff revision 1)

Show all issues

Can you leave the G_GNUC_UNUSED out of the prototypes? Just for one less place to update later if it becomes used.

grim Oct. 4, 2022, 2:53 a.m.
```
That appears to be fine.
```

libpurple/protocols/jabber/jabber.h (Diff revision 1)
Show all issues
```
Same question.
```

Change Summary:

Remove G_GNUC_UNUSED from prototypes

Commits:

	Summary	ID
	Pass the PurpleProtocol objects to all methods of the class Previously login, close, and status_types weren't passed the PurpleProtocol object, this fixes that so that these methods fit the normal pattern for GObjects and it might handy in the future for other protocols.	8c57f363eeedb32712289414747057ea70f0312a
	Pass the PurpleProtocol objects to all methods of the class Previously login, close, and status_types weren't passed the PurpleProtocol object, this fixes that so that these methods fit the normal pattern for GObjects and it might handy in the future for other protocols.	004b32f92351c1a8e946c64de71857c4df5c083a

Diff:

Revision 2 (+158 -122)

Show changes

	libpurple/purpleprotocol.h
	libpurple/purpleprotocol.c
	libpurple/protocols/bonjour/bonjour.c
	libpurple/protocols/demo/purpledemoprotocol.c
	libpurple/protocols/facebook/facebook.c
	libpurple/protocols/gg/gg.c
	libpurple/protocols/gg/status.h
	libpurple/protocols/gg/status.c
	7 more

Review Board 6.0.2