Change Summary:
rebased and updated for the changes in /r/1883
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1078 -8) |
Review Request #1880 — Created Oct. 3, 2022 and submitted
This does't login or do anything protocol wise, it is only establishing a TCP connection.
Connected to a local ergo instance over a plaintext connection and verified I saw the
Successfully connected
message in my output.
rebased and updated for the changes in /r/1883
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1078 -8) |
libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 2) |
---|
This shouldn't be in both
_init
and_constructed
, should it?
libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 2) |
---|
Instead of picking up the
PurpleConnection
from thePurpleAccount
, that object could be passed in from the caller, which has it.
Or this function could return aFurther reading shows that thegboolean
andGError
, and the caller could be the one that handles thePurpleConnection
part entirely, just like is done forpurple_ircv3_connection_valid
.PurpleConnection
is passed on to the callbacks so we can't avoid it being in this function.
remove the cancellable from the
_init
function
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1076 -8) |