Add the ability to connect to IRCv3

Review Request #1880 — Created Oct. 3, 2022 and submitted

Information

pidgin/pidgin
default

Reviewers

This does't login or do anything protocol wise, it is only establishing a TCP
connection.

Connected to a local ergo instance over a plaintext connection and verified I saw the Successfully connected message in my output.

Summary ID
Add the ability to connect to IRCv3
This does't login or do anything protocol wise, it is only establishing a TCP connection.
0d87c4c0e54dbbfcfdcea054e2a6fe410bf2ae7d
Description From Last Updated

This shouldn't be in both _init and _constructed, should it?

QuLogicQuLogic

Instead of picking up the PurpleConnection from the PurpleAccount, that object could be passed in from the caller, which has …

QuLogicQuLogic
grim
QuLogic
  1. 
      
  2. libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 2)
     
     
     
     
     
     
     
     

    This shouldn't be in both _init and _constructed, should it?

  3. Instead of picking up the PurpleConnection from the PurpleAccount, that object could be passed in from the caller, which has it.

    Or this function could return a gboolean and GError, and the caller could be the one that handles the PurpleConnection part entirely, just like is done for purple_ircv3_connection_valid. Further reading shows that the PurpleConnection is passed on to the callbacks so we can't avoid it being in this function.

    1. I'm planning on reworking PurpleProtocol->login to return a connection and to make PurpleConnection dervivable which will clean this up.

  4. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...