Summary

Use gUPnP to determine external IP address and control URL

Review Request #1785 — Created Sept. 18, 2022 and submitted Sept. 18, 2022, 4:05 a.m.

Owner

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

1786

Groups

People

Description

This is based on the gUPnP example, but modified to use the async API, and its context manager to automatically check all interfaces.

Testing Done

Opened prefs and checked that external IP was detected with a UPnP-enabled router.

Commits

Summary	ID
Use GUPnP to determine external IP address and control URL	d586dfa56b6480af87428b264ed32581a3d58a8f

Issues

Description	From	Last Updated
don't we need this in the pkg-config file too?	grim	Sept. 18, 2022, 3:41 a.m.
I thought we were just going to start using g_message and friends..	grim	Sept. 18, 2022, 3:22 a.m.

libpurple/meson.build (Diff revision 1)

Show all issues

don't we need this in the pkg-config file too?

Only if we include the header in the public file, no?

oh is that the case? yeah I believe that is the case.

libpurple/upnp.c (Diff revision 1)

Show all issues

I thought we were just going to start using g_message and friends..

Don't worry about this, we'll take care of this when we move to a purple-network-manager that handles all of this stuff.

Ship it!

Nice work, but ho boy is this library way more confusing that it should be... Thanks!!

Review Board 6.0.2