Simplify add/remove port control flow

Review Request #1786 — Created Sept. 18, 2022 and submitted

Information

pidgin/pidgin
default

Reviewers

Since this is checking a bunch of enum values and then returning immediately, it seems that a switch is a better option here.

Additionally, purple_upnp_discover handles both undiscovered and in-progress discovering, so no need to special case those here.

Compile only.

Summary ID
Simplify add/remove port control flow
89a1fb52c65c04a7a36f76583b3f9394bfa773e9
grim
  1. Ship It!
  2. Nice work, thanks!!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...