Fix GtkPrivacy to respect privacy settings

Review Request #1463 — Created May 20, 2022 and submitted

Information
belgin
pidgin/pidgin
release-2.x.y
PIDGIN-17137
Reviewers
pidgin 
This patch also makes the Buddy List refresh when the user changes
a setting in the GtkPrivacy window.
Changed privacy settings and they were saved and restored as expected.
Summary 
Fix GtkPrivacy to respect privacy settings
Description From Last Updated

What does this change have to do with GtkPrivacy?

 QuLogicQuLogic
grim
grim 
  1. Ship It!
  2. Nice workd, thanks!!
  3. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 
















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    I forgot to post this review...
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      libpurple/protocols/jabber/jabber.c
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    What does this change have to do with GtkPrivacy?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
        

      1. The account->perm_deny setting gets loaded in libpurple/blist.c:651
        2. 

      2. If the server sends a blocklist, account->perm_deny gets overwritten by this code I deleted, which is already wrong, in my opinion, but it happens even if the server replies with an empty blocklist, which happened to me, which is even more wrong. (also, as far as i can tell, that if is pointless)
        3. 

      3. At pidgin/gtkprivacy.c:376 the initial block mode is selected from the dropdown based on account->perm_deny, so if the server sends a blocklist, the user always sees the blocklist block mode being selected
        4. 

      

      I thought about changing the if to if (account->perm_deny == PURPLE_PRIVACY_ALLOW_ALL) so only the default setting gets overwritten, but then if the user explicitly wants to allow all, it will still get overwritten incorrectly, so I just deleted the thing.
      
 
      

      2. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 









     

    

   

  

  

   
   Loading...