Summary

Fix GtkPrivacy to respect privacy settings

Review Request #1463 — Created May 20, 2022 and submitted May 24, 2022, 1:31 a.m.

Information

Owner

belgin

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

PIDGIN-17137

Depends On

Reviewers

Groups

pidgin

People

Description

This patch also makes the Buddy List refresh when the user changes
a setting in the GtkPrivacy window.

Testing Done

Changed privacy settings and they were saved and restored as expected.

Commits

Summary	ID
Fix GtkPrivacy to respect privacy settings This patch also makes the Buddy List refresh when the user changes a setting in the GtkPrivacy window.	991c603891113610580eb8c6156d8131bfab0406

Issues

Description	From	Last Updated
What does this change have to do with GtkPrivacy?	QuLogic	May 24, 2022, 1:43 a.m.

Ship it!

```
Ship It!
```
```
Nice workd, thanks!!
```

Status: Closed (submitted)

Fix it!

```
I forgot to post this review...
```

libpurple/protocols/jabber/jabber.c (Diff revision 1)

Show all issues

What does this change have to do with GtkPrivacy?

belgin May 24, 2022, 6:40 a.m.

The account->perm_deny setting gets loaded in libpurple/blist.c:651
If the server sends a blocklist, account->perm_deny gets overwritten by this code I deleted, which is already wrong, in my opinion, but it happens even if the server replies with an empty blocklist, which happened to me, which is even more wrong. (also, as far as i can tell, that if is pointless)
At pidgin/gtkprivacy.c:376 the initial block mode is selected from the dropdown based on account->perm_deny, so if the server sends a blocklist, the user always sees the blocklist block mode being selected

I thought about changing the if to if (account->perm_deny == PURPLE_PRIVACY_ALLOW_ALL) so only the default setting gets overwritten, but then if the user explicitly wants to allow all, it will still get overwritten incorrectly, so I just deleted the thing.