Add GTK4 viewer outline

Review Request #992 — Created Oct. 4, 2021 and submitted

Information

gplugin/gplugin
default
991

Reviewers

This does nothing since the widget isn't implemented, but it's setup to use GTK4 paradigms.

Compile and run gplugin-gtk4-viewer with the various options, and some temporary debug prints.

Summary ID
Add GTK4 viewer outline
This does nothing since the widget isn't implemented, but it's setup to use GTK4 paradigms.
35a9e828a7b120b532b1e04fa3fd1cc18ecb2324
Description From Last Updated

So you say this is WIP.. does that mean I shouldn't merge it?

grimgrim

should we have a gtk4 or gtk item in here?

grimgrim

can't we set these in glade?

grimgrim
grim
  1. 
      
  2. should we have a gtk4 or gtk item in here?

    1. They can't be loaded in the same process, so it shouldn't conflict, I think. I don't believe GTK4's resources get the 4 suffix either.

    2. Cool, I didn't think as much but wanted a sanity check.

  3. can't we set these in glade?

    1. I copied it from what Builder produced, but we can move it. I just wasn't sure what was the right size just yet.

    2. gotcha

  4. 
      
grim
  1. 
      
  2. So you say this is WIP.. does that mean I shouldn't merge it?

    1. I guess you could, but it'd just be an empty window... I may amend a few fixes as things get done for the real widget, so that's why I said WIP.

    2. Cool I won't merge then :)

  3. 
      
QuLogic
QuLogic
grim
  1. Ship It!
  2. Awesome work! I like how you took a very incremental approach to this to, makes it much easier to review I'll do my best to take that hint :-D

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...