Add an unloadable property to GPluginPluginInfo and add a shutdown parameter to gplugin_unload.

Review Request #943 — Created Sept. 25, 2021 and submitted

Information

gplugin/gplugin
default

Reviewers

Add an unloadable property to GPluginPluginInfo and add a shutdown parameter to gplugin_unload.

This allows plugins that can only be shutdown once to handle things properly. Examples of this are basically anything that pulls in another library that doesn't allow you to _init and _uninit more than once.

Ran the unit tests and gplugin-query.

Summary ID
Add an unloadable property to GPluginPluginInfo and add a shutdown parameter to gplugin_unload.
30bd12b49df3f3d6f74a9e1885e594509c5e35aa
Description From Last Updated

Whether

QuLogicQuLogic

s/a the/the/ s/and can/can/

QuLogicQuLogic

unloadable

QuLogicQuLogic

I'd put a space between if and ( since there's one between ) and then. Also, the indent appears to …

QuLogicQuLogic

Did you manage to actually fix it with a ref? Or with this set context?

QuLogicQuLogic

PyBool_FromLong seems better here.

QuLogicQuLogic
grim
grim
QuLogic
  1. 
      
  2. gplugin/gplugin-loader.c (Diff revision 2)
     
     
    Show all issues

    Whether

  3. gplugin/gplugin-plugin-info.c (Diff revision 2)
     
     
    Show all issues

    s/a the/the/

    s/and can/can/

  4. gplugin/gplugin-plugin-info.c (Diff revision 2)
     
     
    Show all issues

    unloadable

  5. lua/tests/plugins/unload-shutdown.lua (Diff revision 2)
     
     
    Show all issues

    I'd put a space between if and ( since there's one between ) and then.

    Also, the indent appears to be spaces here instead of tabs like the rest.

  6. perl5/gplugin-perl5-loader.c (Diff revision 2)
     
     
     
     
     
    Show all issues

    Did you manage to actually fix it with a ref? Or with this set context?

    1. I dunno, it's just not failing anymore... Best I can figure is that it was a bug in the perl library?

  7. python3/gplugin-python3-loader.c (Diff revision 2)
     
     
    Show all issues

    PyBool_FromLong seems better here.

  8. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed