Summary

Add an unloadable property to GPluginPluginInfo and add a shutdown parameter to gplugin_unload.

Review Request #943 — Created Sept. 25, 2021 and submitted Sept. 27, 2021, 1:42 p.m.

Information

Owner

grim

Repository

gplugin/gplugin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Add an unloadable property to GPluginPluginInfo and add a shutdown parameter to gplugin_unload.

This allows plugins that can only be shutdown once to handle things properly. Examples of this are basically anything that pulls in another library that doesn't allow you to _init and _uninit more than once.

Testing Done

Ran the unit tests and gplugin-query.

Commits

Summary	ID
Add an unloadable property to GPluginPluginInfo and add a shutdown parameter to gplugin_unload.	30bd12b49df3f3d6f74a9e1885e594509c5e35aa

Issues

Description	From	Last Updated
Whether	QuLogic	Sept. 27, 2021, 12:14 a.m.
s/a the/the/ s/and can/can/	QuLogic	Sept. 27, 2021, 12:15 a.m.
unloadable	QuLogic	Sept. 27, 2021, 12:15 a.m.
I'd put a space between if and ( since there's one between ) and then. Also, the indent appears to …	QuLogic	Sept. 27, 2021, 12:16 a.m.
Did you manage to actually fix it with a ref? Or with this set context?	QuLogic	Sept. 27, 2021, 12:16 a.m.
PyBool_FromLong seems better here.	QuLogic	Sept. 27, 2021, 12:17 a.m.

Change Summary:

rebased

Commits:

	Summary	ID
	Add an unloadable property to GPluginPluginInfo and add a shutdown parameter to gplugin_unload.	e06c843de7f8cccf92d02dda4338ff2004405cea
	Add an unloadable property to GPluginPluginInfo and add a shutdown parameter to gplugin_unload.	2c1998a8152a52e0791a63ec4d7709a41a4c5c57

Diff:

Revision 2 (+1374 -290)

Show changes

	meson.build
	gplugin/gplugin-loader.h
	gplugin/gplugin-loader.c
	gplugin/gplugin-loader-tests.c
	gplugin/gplugin-manager.h
	gplugin/gplugin-manager.c
	gplugin/gplugin-native-loader.c
	gplugin/gplugin-native-plugin.h
	83 more

Description:: ~
Add an unloadable property to GPluginPluginInfo and add a shutdown parameter to gplugin_unload.
~
Add an unloadable property to GPluginPluginInfo and add a shutdown parameter to gplugin_unload.

This allows plugins that can only be shutdown once to handle things properly. Examples of this are basically anything that pulls in another library that doesn't allow you to _init and _uninit more than once.

gplugin/gplugin-loader.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Whether
```
gplugin/gplugin-plugin-info.c (Diff revision 2)
The issue has been resolved. Show all issues
```
s/a the/the/
s/and can/can/
```
gplugin/gplugin-plugin-info.c (Diff revision 2)
The issue has been resolved. Show all issues
```
unloadable
```

lua/tests/plugins/unload-shutdown.lua (Diff revision 2)

The issue has been resolved. Show all issues

I'd put a space between if and ( since there's one between ) and then.

Also, the indent appears to be spaces here instead of tabs like the rest.

perl5/gplugin-perl5-loader.c (Diff revision 2)

The issue has been dropped. Show all issues

Did you manage to actually fix it with a ref? Or with this set context?

grim Sept. 26, 2021, 10:28 p.m.

I dunno, it's just not failing anymore... Best I can figure is that it was a bug in the perl library?

python3/gplugin-python3-loader.c (Diff revision 2)
The issue has been resolved. Show all issues
```
PyBool_FromLong seems better here.
```

Change Summary:

addressed review findings

Commits:

	Summary	ID
	Add an unloadable property to GPluginPluginInfo and add a shutdown parameter to gplugin_unload.	2c1998a8152a52e0791a63ec4d7709a41a4c5c57
	Add an unloadable property to GPluginPluginInfo and add a shutdown parameter to gplugin_unload.	30bd12b49df3f3d6f74a9e1885e594509c5e35aa

Diff:

Revision 3 (+1374 -290)

Show changes

	meson.build
	gplugin/gplugin-loader.h
	gplugin/gplugin-loader.c
	gplugin/gplugin-loader-tests.c
	gplugin/gplugin-manager.h
	gplugin/gplugin-manager.c
	gplugin/gplugin-native-loader.c
	gplugin/gplugin-native-plugin.h
	83 more

Ship it!

```
Ship It!
```

Status:: Completed