Change Summary:
rebased
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1374 -290) |
Review Request #943 — Created Sept. 25, 2021 and submitted
Add an unloadable property to GPluginPluginInfo and add a shutdown parameter to
gplugin_unload
.This allows plugins that can only be shutdown once to handle things properly. Examples of this are basically anything that pulls in another library that doesn't allow you to
_init
and_uninit
more than once.
Ran the unit tests and gplugin-query.
Summary | ID |
---|---|
30bd12b49df3f3d6f74a9e1885e594509c5e35aa |
Description | From | Last Updated |
---|---|---|
Whether |
QuLogic | |
s/a the/the/ s/and can/can/ |
QuLogic | |
unloadable |
QuLogic | |
I'd put a space between if and ( since there's one between ) and then. Also, the indent appears to … |
QuLogic | |
Did you manage to actually fix it with a ref? Or with this set context? |
QuLogic | |
PyBool_FromLong seems better here. |
QuLogic |
rebased
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1374 -290) |
Description: |
|
---|
lua/tests/plugins/unload-shutdown.lua (Diff revision 2) |
---|
I'd put a space between
if
and(
since there's one between)
andthen
.Also, the indent appears to be spaces here instead of tabs like the rest.
perl5/gplugin-perl5-loader.c (Diff revision 2) |
---|
Did you manage to actually fix it with a ref? Or with this set context?
addressed review findings
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1374 -290) |