Fix a double free in jabber/message.c and silence a warning

Review Request #932 — Created Sept. 24, 2021 and submitted

grim
pidgin/pidgin
release-2.x.y
PIDGIN-17547
pidgin

Fix a double free in jabber/message.c and silence a warning

JabberBuddyResource is handled internally, but it's free function, which is static, does in fact free the thread_id as well.

Compiled

Summary
Fix a double free in jabber/message.c and silence a warning
Description From Last Updated

The existing comment is actually very close to not triggering the warning: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/protocols/jabber/message.c (Diff revision 1)
     
     
     

    The existing comment is actually very close to not triggering the warning: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...