Summary

Port purple_str_to_time to regex and add additional tests

Review Request #923 — Created Sept. 14, 2021 and submitted Sept. 16, 2021, 9:13 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Port purple_str_to_time to regex and add additional tests

Testing Done

Ran the unit tests with the normal ./autogen.sh as well as a setup for fuzzing.

Commits

Summary	ID
Port purple_str_to_time to regex and add additional tests	0d249d63b6c5fd868290f6276f4885f0cd396241

Issues

Description	From	Last Updated
Should the pattern be anchored?	QuLogic	Sept. 16, 2021, 8:45 p.m.
This should stay?	QuLogic	Sept. 16, 2021, 8:57 p.m.
This year was previously only allowed if >= 1900.	QuLogic	Sept. 16, 2021, 8:57 p.m.
Should check match itself as well.	QuLogic	Sept. 16, 2021, 8:49 p.m.
Should check match as well.	QuLogic	Sept. 16, 2021, 8:49 p.m.

Change Summary:

rebased

Commits:

	Summary	ID
	Port purple_str_to_time to regex and add additional tests	526ae9df11a57c2399ad2bda035ec6d135721d40
	Port purple_str_to_time to regex and add additional tests	399e5c942afe0453f02c051c05cde160d3cd0073

Diff:

Revision 2 (+366 -276)

Show changes

	libpurple/util.c
	libpurple/tests/test_util.c

Change Summary:

fix some leaks and make the regex match raw to help with the fuzzer, but maybe the fuzzer should just check if it has utf8, not sure..

Commits:

	Summary	ID
	Port purple_str_to_time to regex and add additional tests	399e5c942afe0453f02c051c05cde160d3cd0073
	Port purple_str_to_time to regex and add additional tests	b0517a68e3d6e8338294f25fa5dcc38f1afb6480

Diff:

Revision 3 (+378 -276)

Show changes

	libpurple/util.c
	libpurple/tests/test_util.c

libpurple/util.c (Diff revision 3)

The issue has been resolved. Show all issues

Should the pattern be anchored?

grim Sept. 16, 2021, 3:32 p.m.

Maybe at the start? The end shouldn't as the function has that rest return parameter.

libpurple/util.c (Diff revision 3)

The issue has been resolved. Show all issues

This should stay?

grim Sept. 16, 2021, 3:32 p.m.

This shouldn't handled by lines 770 and 779.

grim Sept. 16, 2021, 8:49 p.m.

Just noticed that this was before a g_return_if_fail will fix.

libpurple/util.c (Diff revision 3)

The issue has been resolved. Show all issues

This year was previously only allowed if >= 1900.

grim Sept. 16, 2021, 3:32 p.m.

It used year >= 1900 to see if it was set before. Now the year group is checked before trailingyear is checked.

grim Sept. 16, 2021, 8:52 p.m.

nm, I see what you're talking about now.

libpurple/util.c (Diff revision 3)
The issue has been resolved. Show all issues
```
Should check match itself as well.
```
libpurple/util.c (Diff revision 3)
The issue has been resolved. Show all issues
```
Should check match as well.
```

Commits:

	Summary	ID
	Port purple_str_to_time to regex and add additional tests	b0517a68e3d6e8338294f25fa5dcc38f1afb6480
	Port purple_str_to_time to regex and add additional tests	19912393e549fc5725bba48e35239fe8b879107b

Diff:

Revision 4 (+378 -276)

Show changes

	libpurple/util.c
	libpurple/tests/test_util.c

Change Summary:

anchor the start of the regex.

Commits:

	Summary	ID
	Port purple_str_to_time to regex and add additional tests	19912393e549fc5725bba48e35239fe8b879107b
	Port purple_str_to_time to regex and add additional tests	3323ed4f17b90b1d8a6d1747e25bcbb02d302843

Diff:

Revision 5 (+378 -276)

Show changes

	libpurple/util.c
	libpurple/tests/test_util.c

Commits:

	Summary	ID
	Port purple_str_to_time to regex and add additional tests	3323ed4f17b90b1d8a6d1747e25bcbb02d302843
	Port purple_str_to_time to regex and add additional tests	0d249d63b6c5fd868290f6276f4885f0cd396241

Diff:

Revision 6 (+390 -274)

Show changes

	libpurple/util.c
	libpurple/tests/test_util.c

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

I don't confess to having read the entire regex, but...

Status:: Completed