- Download Diff

Summary:

Port purple_str_to_time to regex and add additional tests

Review Request #923 — Created Sept. 14, 2021 and submitted Sept. 17, 2021, 2:13 a.m.

Information
Owner:	grim
Repository:	pidgin/pidgin
Branch:	release-2.x.y
Bugs:
Depends On:
Reviewers
Groups:	pidgin
People:

Description

Port purple_str_to_time to regex and add additional tests

Testing Done

Ran the unit tests with the normal ./autogen.sh as well as a setup for fuzzing.

Commits

Summary
Port purple_str_to_time to regex and add additional tests

Screenshots

Issues

Description	From	Last Updated
Should the pattern be anchored?	QuLogic	Sept. 17, 2021, 1:45 a.m.
This should stay?	QuLogic	Sept. 17, 2021, 1:57 a.m.
This year was previously only allowed if >= 1900.	QuLogic	Sept. 17, 2021, 1:57 a.m.
Should check match itself as well.	QuLogic	Sept. 17, 2021, 1:49 a.m.
Should check match as well.	QuLogic	Sept. 17, 2021, 1:49 a.m.

Change Summary:

rebased

Commits:

	Summary
-	Port purple_str_to_time to regex and add additional tests
+	Port purple_str_to_time to regex and add additional tests

Diff:

Revision 2 (+366 -276)

Show changes

	libpurple/util.c
	libpurple/tests/test_util.c

Change Summary:

fix some leaks and make the regex match raw to help with the fuzzer, but maybe the fuzzer should just check if it has utf8, not sure..

Commits:

	Summary
-	Port purple_str_to_time to regex and add additional tests
+	Port purple_str_to_time to regex and add additional tests

Diff:

Revision 3 (+378 -276)

Show changes

	libpurple/util.c
	libpurple/tests/test_util.c

libpurple/util.c (Diff revision 3)

Show all issues

Should the pattern be anchored?

grim Sept. 16, 2021, 8:32 p.m.

Maybe at the start? The end shouldn't as the function has that rest return parameter.

libpurple/util.c (Diff revision 3)

Show all issues

This should stay?

grim Sept. 16, 2021, 8:32 p.m.

This shouldn't handled by lines 770 and 779.

grim Sept. 17, 2021, 1:49 a.m.

Just noticed that this was before a g_return_if_fail will fix.

libpurple/util.c (Diff revision 3)

Show all issues

This year was previously only allowed if >= 1900.

grim Sept. 16, 2021, 8:32 p.m.

It used year >= 1900 to see if it was set before. Now the year group is checked before trailingyear is checked.

grim Sept. 17, 2021, 1:52 a.m.

nm, I see what you're talking about now.

libpurple/util.c (Diff revision 3)
Show all issues
```
Should check match itself as well.
```
libpurple/util.c (Diff revision 3)
Show all issues
```
Should check match as well.
```

Commits:

	Summary
-	Port purple_str_to_time to regex and add additional tests
+	Port purple_str_to_time to regex and add additional tests

Diff:

Revision 4 (+378 -276)

Show changes

	libpurple/util.c
	libpurple/tests/test_util.c

Change Summary:

anchor the start of the regex.

Commits:

	Summary
-	Port purple_str_to_time to regex and add additional tests
+	Port purple_str_to_time to regex and add additional tests

Diff:

Revision 5 (+378 -276)

Show changes

	libpurple/util.c
	libpurple/tests/test_util.c

Commits:

	Summary
-	Port purple_str_to_time to regex and add additional tests
+	Port purple_str_to_time to regex and add additional tests

Diff:

Revision 6 (+390 -274)

Show changes

	libpurple/util.c
	libpurple/tests/test_util.c

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

I don't confess to having read the entire regex, but...

You have a pending review.

Review Board 4.0.4

Port purple_str_to_time to regex and add additional tests

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Commits:

Diff:

Status: Closed (submitted)