Port purple_str_to_time to regex and add additional tests

Review Request #923 — Created Sept. 14, 2021 and submitted

grim
pidgin/pidgin
release-2.x.y
pidgin
Port purple_str_to_time to regex and add additional tests

Ran the unit tests with the normal ./autogen.sh as well as a setup for fuzzing.

Summary
Port purple_str_to_time to regex and add additional tests
Description From Last Updated

Should the pattern be anchored?

QuLogicQuLogic

This should stay?

QuLogicQuLogic

This year was previously only allowed if >= 1900.

QuLogicQuLogic

Should check match itself as well.

QuLogicQuLogic

Should check match as well.

QuLogicQuLogic
grim
grim
QuLogic
  1. 
      
  2. libpurple/util.c (Diff revision 3)
     
     

    Should the pattern be anchored?

    1. Maybe at the start? The end shouldn't as the function has that rest return parameter.

  3. libpurple/util.c (Diff revision 3)
     
     
     

    This should stay?

    1. This shouldn't handled by lines 770 and 779.

    2. Just noticed that this was before a g_return_if_fail will fix.

  4. libpurple/util.c (Diff revision 3)
     
     

    This year was previously only allowed if >= 1900.

    1. It used year >= 1900 to see if it was set before. Now the year group is checked before trailingyear is checked.

    2. nm, I see what you're talking about now.

  5. libpurple/util.c (Diff revision 3)
     
     

    Should check match itself as well.

  6. libpurple/util.c (Diff revision 3)
     
     

    Should check match as well.

  7. 
      
grim
grim
grim
rekkanoryo
  1. Ship It!
  2. 
      
QuLogic
  1. Ship It!
  2. I don't confess to having read the entire regex, but...

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...