Change Summary:
add some more to the corpus for str_to_time
Commits: |
|
||||||
---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+782 -72) |
Review Request #920 — Created Sept. 13, 2021 and submitted
Information | |
---|---|
grim | |
pidgin/pidgin | |
release-2.x.y | |
Reviewers | |
pidgin | |
Clean up all of the fuzzers and add a corpus for all of them
Ran all of the fuzzers, made sure they were able to add new corpra.
Summary |
---|
Description | From | Last Updated |
---|---|---|
Should we wrap some in g_utf8_validate? |
|
|
This is the LLVM fuzzer's prototype, so I'm not sure we should change types on it. |
|
|
This needs to check input length like the downstream fuzzer, or else you'll get assert bugs like https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34999 (the downstream … |
|
|
Extra semicolon |
|
|
You could put this back since the fuzzer doesn't check round-tripping any more? |
|
|
Didn't you want to change the type here? |
|
|
Extra blank line, compared to the others. |
|
|
Change types? |
|
|
Extra blank line. |
|
|
Change types? |
|
|
Change types. |
|
add some more to the corpus for str_to_time
Commits: |
|
||||||
---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+782 -72) |
FUZZING (Diff revision 2) |
---|
This is the LLVM fuzzer's prototype, so I'm not sure we should change types on it.
libpurple/fuzzers/fuzz_base16_decode.c (Diff revision 2) |
---|
This needs to check input length like the downstream fuzzer, or else you'll get assert bugs like https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34999 (the downstream checks are buggy or they wouldn't hit this.)
This may apply to other expected constraints in other tested functions.
Commits: |
|
||||||
---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+788 -72) |
rebased
Commits: |
|
||||||
---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+788 -72) |
call purple_util_init and purple_util_uninit in the str_to_time fuzzer
Commits: |
|
||||||
---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+796 -72) |
add g_utf8_validate_len to the functions that need it and add some new corpus from running the fuzzers with that code change.
Also skipped the xmlnode equality check because the fuzzer was putting white space in that was screwing stuff up.
Commits: |
|
||||||
---|---|---|---|---|---|---|---|
Diff: |
Revision 6 (+936 -96) |
libpurple/fuzzers/corpus/xmlnode/b9f27c892298045dcb9d56b30d19cf51994fc7de (Diff revisions 5 - 6) |
---|
You could put this back since the fuzzer doesn't check round-tripping any more?
Commits: |
|
||||||
---|---|---|---|---|---|---|---|
Diff: |
Revision 7 (+964 -124) |
Commits: |
|
||||||
---|---|---|---|---|---|---|---|
Diff: |
Revision 8 (+994 -170) |