Clean up all of the fuzzers and add a corpus for all of them

Review Request #920 — Created Sept. 13, 2021 and submitted

grim
pidgin/pidgin
release-2.x.y
pidgin
Clean up all of the fuzzers and add a corpus for all of them

Ran all of the fuzzers, made sure they were able to add new corpra.

Summary
Clean up all of the fuzzers and add a corpus for all of them
Description From Last Updated

Should we wrap some in g_utf8_validate?

QuLogicQuLogic

This is the LLVM fuzzer's prototype, so I'm not sure we should change types on it.

QuLogicQuLogic

This needs to check input length like the downstream fuzzer, or else you'll get assert bugs like https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34999 (the downstream ...

QuLogicQuLogic

Extra semicolon

QuLogicQuLogic

You could put this back since the fuzzer doesn't check round-tripping any more?

QuLogicQuLogic

Didn't you want to change the type here?

QuLogicQuLogic

Extra blank line, compared to the others.

QuLogicQuLogic

Change types?

QuLogicQuLogic

Extra blank line.

QuLogicQuLogic

Change types?

QuLogicQuLogic

Change types.

QuLogicQuLogic
grim
QuLogic
  1. 
      
  2. FUZZING (Diff revision 2)
     
     

    This is the LLVM fuzzer's prototype, so I'm not sure we should change types on it.

    1. But then we need to include additional files...

  3. libpurple/fuzzers/fuzz_base16_decode.c (Diff revision 2)
     
     

    This needs to check input length like the downstream fuzzer, or else you'll get assert bugs like https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34999 (the downstream checks are buggy or they wouldn't hit this.)

    This may apply to other expected constraints in other tested functions.

    1. Note, the actual full trace on https://oss-fuzz.com/testcase-detail/5640002393473024 is actually about a memory leak, so not sure if the assert is really a problem or just something that gets auto-reported when any other issues arise.

  4. libpurple/fuzzers/fuzz_markup_linkify.c (Diff revision 2)
     
     

    Extra semicolon

  5. 
      
grim
QuLogic
  1. 
      
  2. Should we wrap some in g_utf8_validate?

    1. the fuzzer or the function?

    2. Just the fuzzers that need it.

  3. 
      
grim
grim
grim
QuLogic
  1. 
      
  2. You could put this back since the fuzzer doesn't check round-tripping any more?

  3. libpurple/fuzzers/fuzz_html_to_xhtml.c (Diff revision 6)
     
     

    Didn't you want to change the type here?

  4. libpurple/fuzzers/fuzz_html_to_xhtml.c (Diff revision 6)
     
     

    Extra blank line, compared to the others.

  5. libpurple/fuzzers/fuzz_jabber_caps.c (Diff revision 6)
     
     

    Change types?

  6. libpurple/fuzzers/fuzz_jabber_caps.c (Diff revision 6)
     
     

    Extra blank line.

  7. Change types?

  8. libpurple/fuzzers/fuzz_xmlnode.c (Diff revision 6)
     
     

    Change types.

  9. 
      
grim
grim
grim
  1. Ship It!
  2. 
      
rekkanoryo
  1. Ship It!
  2. 
      
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...