Fix leak that may occur when xmlnode_from_str fails

Review Request #911 — Created Sept. 9, 2021 and submitted Sept. 13, 2021, 10:08 p.m.

Information
Owner:	QuLogic
Repository:	pidgin/pidgin
Branch:	release-2.x.y
Bugs:
Depends On:
Reviewers
Groups:	pidgin
People:

Description

The failure may occur any time in the middle of parsing, and xpd->current may
not actually be pointing to the root of the parsed tree. Thus we need to walk
back up before freeing the xmlnode.

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34988

Testing Done

Ran the reproducer testcase on fuzz_xml

Commits

Summary
	Fix leak that may occur when xmlnode_from_str fails.

Screenshots

Issues

Description	From	Last Updated

Expand All
Collapse All

Groups:

-	pidgin

Change Summary:

Remove from pidgin group

Testing Done:

~		Ran the reproducer testcase on `fuzz_xml`.
	~	Ran the reproducer testcase on `fuzz_xml`

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Status: Re-opened

Groups:

-	security
+	pidgin

You have a pending review.

Review Board 5.0.3

Fix leak that may occur when xmlnode_from_str fails

Groups:

Change Summary:

Testing Done:

Status: Closed (submitted)

Status: Re-opened

Groups:

Status: Closed (submitted)