Summary

Fix leak that may occur when xmlnode_from_str fails

Review Request #911 — Created Sept. 9, 2021 and submitted Sept. 13, 2021, 5:08 p.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

The failure may occur any time in the middle of parsing, and xpd->current may
not actually be pointing to the root of the parsed tree. Thus we need to walk
back up before freeing the xmlnode.

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34988

Testing Done

Ran the reproducer testcase on fuzz_xml

Commits

Summary	ID
Fix leak that may occur when xmlnode_from_str fails. The failure may occur any time in the middle of parsing, and `xpd->current` may not actually be pointing to the root of the parsed tree. Thus we need to walk back up before freeing the xmlnode. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34988	6a017d19a63a8368dc60d39806eebf0f9f1b0810

Groups:: pidgin

Change Summary:: Remove from pidgin group
Testing Done:: ~
Ran the reproducer testcase on fuzz_xml.
~
Ran the reproducer testcase on fuzz_xml

Ship it!

```
Ship It!
```

Status:: Completed

Status:: Re-opened

Groups:: security
pidgin

Status:: Completed