Replace the deprecated API in gtkaccount.c

Review Request #906 — Created Aug. 27, 2021 and submitted

grim
pidgin/pidgin
default
pidgin
Replace the deprecated API in gtkaccount.c

Verified that all of the dialog buttons still function as intended.

Summary
Replace the deprecated API in gtkaccount.c
Description From Last Updated

I don't think the GTK_RESPONSE_* codes are deprecated; can those be used here?

QuLogicQuLogic
grim
QuLogic
  1. 
      
  2. pidgin/gtkaccount.c (Diff revision 1)
     
     
     
     
     
     
     

    I don't think the GTK_RESPONSE_* codes are deprecated; can those be used here?

    1. They're not deprecated, I choose to use new enums so it was more obvious as to what was what. Ie using RESPONSE_SAVE vs GTK_RESPONSE_OK or GTK_RESPONSE_ACCEPT or GTK_RESPONSE_APPLY. If we'd rather go that route we can, this just seemed like a better alternative.

      The actual deprecated function is gtk_dialog_get_action_area which was/is used by pidgin_dialog_add_button, so I replaced the pidgin_dialog_add_button usage with gtk_dialog_add_button which uses the responses.

  3. 
      
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...