Summary

Don't error out when trying to remove a password that isn't stored.

Review Request #901 — Created Aug. 23, 2021 and submitted Aug. 23, 2021, 12:16 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Both wincred and secretservice return an error if you try to delete a password
that they don't know about. We don't care about this scenario and just want to
make sure the password is gone, so we changed the expected behavior to be as
such and updated wincred and secret service for the change.

I also fixed the NULL deference which is how I stumbled across the issue in the
first place.

Testing Done


Verfied the issue was fixed in secretservice.
Verfied the issue didn't exist in kwallet.

Commits

Summary	ID
Don't error out when trying to remove a password that isn't stored. Both wincred and secretservice return an error if you try to delete a password that they don't know about. We don't care about this scenario and just want to make sure the password is gone, so we changed the expected behavior to be as such and updated wincred and secret service for the change. I also fixed the NULL deference which is how I stumbled across the issue in the first place.	22d0892e22cae4a29fba0ec5a202302bd0f5e102

Summary

Don't error out when trying to remove a password that isn't stored.

Both wincred and secretservice return an error if you try to delete a password that they don't know about. We don't care about this scenario and just want to make sure the password is gone, so we changed the expected behavior to be as such and updated wincred and secret service for the change. I also fixed the NULL deference which is how I stumbled across the issue in the first place.

22d0892e22cae4a29fba0ec5a202302bd0f5e102

Issues

Description	From	Last Updated
we	QuLogic	Aug. 23, 2021, 12:15 p.m.

Ship it!

```
Ship It!
```
libpurple/plugins/keyrings/secretservice.c (Diff revision 1)
Show all issues
```
we
```

Commits:

	Summary	ID
	Don't error out when trying to remove a password that isn't stored. Both wincred and secretservice return an error if you try to delete a password that they don't know about. We don't care about this scenario and just want to make sure the password is gone, so we changed the expected behavior to be as such and updated wincred and secret service for the change. I also fixed the NULL deference which is how I stumbled across the issue in the first place.	80622d5b8430a1242f3ad42c73bb8c65b1c7e2ab
	Don't error out when trying to remove a password that isn't stored. Both wincred and secretservice return an error if you try to delete a password that they don't know about. We don't care about this scenario and just want to make sure the password is gone, so we changed the expected behavior to be as such and updated wincred and secret service for the change. I also fixed the NULL deference which is how I stumbled across the issue in the first place.	22d0892e22cae4a29fba0ec5a202302bd0f5e102

Diff:

Revision 2 (+58 -54)

Show changes

	libpurple/accounts.c
	libpurple/purplecredentialmanager.h
	libpurple/purplecredentialprovider.h
	libpurple/plugins/keyrings/secretservice.c
	libpurple/plugins/keyrings/wincred.c

Review Board 6.0.2

Don't error out when trying to remove a password that isn't stored.

Information

Reviewers

Commits:

Diff:

Status: Closed (submitted)