Summary

fix memory leak reported by valgrind when running test-versioned-dependencies and test-find-plugins

Review Request #896 — Created Aug. 11, 2021 and submitted Aug. 19, 2021, 9:27 p.m.

Information

Owner

ivanhoe

Repository

gplugin/gplugin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

fix memory leak reported by valgrind when running test-versioned-dependencies and test-find-plugins

Testing Done

ran all tests in valgrind

Commits

Summary	ID	Author
fix memory leak reported by valgrind when running test-versioned-dependencies and test-find-plugins	f3293137f9c022980fd18817471a567e08cc98cb	ivanhoe
fix possible leaking loader for early returns too	13ba4a74a7b012406651d5fa8dd3b53043185943	ivanhoe
removed gotos	14c62a0c7ec2e2ded686dd729625b39a1d6d06b1	ivanhoe

Issues

Description	From	Last Updated
That means this also leaks on the early return, I think?	QuLogic	Aug. 17, 2021, 6:52 p.m.
Ditto.	QuLogic	Aug. 17, 2021, 6:52 p.m.
we don't really condone the use of goto's...	grim	Aug. 19, 2021, 4:40 p.m.

Ship it!

```
Ship It!
```
```
Nice find! Thanks!!
```

gplugin/gplugin-manager.c (Diff revision 1)

Show all issues

That means this also leaks on the early return, I think?

gplugin/gplugin-manager.c (Diff revision 1)
Show all issues
```
Ditto.
```

Change Summary:

Fix issues raised by QuLogic.

Commits:

Summary	ID	Author
fix memory leak reported by valgrind when running test-versioned-dependencies and test-find-plugins	5d285368cdfa1d0636592a22d8348ce673fc62a4	ivanhoe
fix memory leak reported by valgrind when running test-versioned-dependencies and test-find-plugins	f3293137f9c022980fd18817471a567e08cc98cb	ivanhoe
fix possible leaking loader for early returns too	13ba4a74a7b012406651d5fa8dd3b53043185943	ivanhoe

Diff:

Revision 2 (+24 -8)

Show changes

gplugin/gplugin-manager.c

gplugin/gplugin-manager.c (Diff revision 2)
Show all issues
```
we don't really condone the use of goto's...
```

Change Summary:

removed gotos

Commits:

Summary	ID	Author
fix memory leak reported by valgrind when running test-versioned-dependencies and test-find-plugins	f3293137f9c022980fd18817471a567e08cc98cb	ivanhoe
fix possible leaking loader for early returns too	13ba4a74a7b012406651d5fa8dd3b53043185943	ivanhoe
fix memory leak reported by valgrind when running test-versioned-dependencies and test-find-plugins	f3293137f9c022980fd18817471a567e08cc98cb	ivanhoe
fix possible leaking loader for early returns too	13ba4a74a7b012406651d5fa8dd3b53043185943	ivanhoe
removed gotos	14c62a0c7ec2e2ded686dd729625b39a1d6d06b1	ivanhoe

Diff:

Revision 3 (+28 -12)

Show changes

gplugin/gplugin-manager.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

fix memory leak reported by valgrind when running test-versioned-dependencies and test-find-plugins

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)