Add a bunch of icon name utility functions

Review Request #891 — Created Aug. 10, 2021 and submitted

grim
pidgin/pidgin
default
pidgin
Add a bunch of icon name utility functions

Verified that PidginPresenceIcon still worked as expected.

Summary
Add a bunch of icon name utility functions
Description From Last Updated

This file is all space indent?

QuLogicQuLogic

Not sure, but the current line is different from the other functions. I was expecting to see this? However, I ...

jrchampjrchamp
jrchamp
  1. The code all made sense to me, except for one thing that I was unsure about.

  2. pidgin/pidginiconname.c (Diff revision 1)
     
     

    Not sure, but the current line is different from the other functions. I was expecting to see this? However, I don't see it used anywhere else in the codebase, so I'm not sure.

        if(!PURPLE_IS_STATUS_TYPE(type)) {
    
    1. PurpleStatusType is a boxed type that means it's just a structure with _copy and _free function. As such is does not have a type checking function like the others.

  3. 
      
QuLogic
  1. 
      
  2. pidgin/pidginiconname.c (Diff revision 1)
     
     

    This file is all space indent?

    1. ugh sublime got confused somehow and apparently I missed this one.. sorry about that.

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...