Summary

Add a bunch of icon name utility functions

Review Request #891 — Created Aug. 10, 2021 and submitted Aug. 14, 2021, 4:15 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Add a bunch of icon name utility functions

Testing Done

Verified that PidginPresenceIcon still worked as expected.

Commits

Summary	ID
Add a bunch of icon name utility functions	df7a0fc5157722b64c2e1355d1d616eff2cbf11b

Issues

Description	From	Last Updated
This file is all space indent?	QuLogic	Aug. 14, 2021, 4:10 a.m.
Not sure, but the current line is different from the other functions. I was expecting to see this? However, I …	jrchamp	Aug. 14, 2021, 4:09 a.m.

Ship it!

The code all made sense to me, except for one thing that I was unsure about.

pidgin/pidginiconname.c (Diff revision 1)

Show all issues

Not sure, but the current line is different from the other functions. I was expecting to see this? However, I don't see it used anywhere else in the codebase, so I'm not sure.

    if(!PURPLE_IS_STATUS_TYPE(type)) {

grim Aug. 11, 2021, 12:45 a.m.

PurpleStatusType is a boxed type that means it's just a structure with _copy and _free function. As such is does not have a type checking function like the others.

pidgin/pidginiconname.c (Diff revision 1)

Show all issues

This file is all space indent?

grim Aug. 14, 2021, 3:56 a.m.

ugh sublime got confused somehow and apparently I missed this one.. sorry about that.

Change Summary:

rebased and fixed indentation.

Commits:

	Summary	ID
	Add a bunch of icon name utility functions	2a2c1a1a3455afcafe7ac3f1b3ec9df7b9b4d23f
	Add a bunch of icon name utility functions	df7a0fc5157722b64c2e1355d1d616eff2cbf11b

Diff:

Revision 2 (+376 -308)

Show changes

	doc/reference/pidgin/pidgin-docs.xml
	pidgin/meson.build
	pidgin/pidginicon.h
	pidgin/pidginiconname.c
	pidgin/pidgininfopane.c
	pidgin/pidginpresence.h
	pidgin/pidginpresence.c
	pidgin/pidginpresenceicon.c
	1 more