Summary

Change PurpleMessage:id to a string and add author-name-color to the property getter/setter

Review Request #876 — Created Aug. 4, 2021 and submitted Aug. 7, 2021, 4:07 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

877

Commit

b7ad5e7579eb

Reviewers

Groups

pidgin

People

Description

Change PurpleMessage:id to a string and add author-name-color to the property getter/setter.

This is in conflict with the TalkatuMessage:id property which will be addressed in another review request but Pidgin seems to run fine right now with this conflict.

Testing Done

Compiled and ran locally against the history-api branch.

Expand All
Collapse All

Ship it!

```
Ship It!
```

libpurple/purplemessage.c (Diff revision 1)

Was this incorrectly not construct-only readwrite before?

grim Aug. 7, 2021, 3:58 a.m.

correct, we found out the hard way when unserializing messages via the history api.

Status:: Completed