Change PurpleMessage:id to a string and add author-name-color to the property getter/setter

Review Request #876 — Created Aug. 5, 2021 and submitted

grim
pidgin/pidgin
default
877
b7ad5e7579eb
pidgin

Change PurpleMessage:id to a string and add author-name-color to the property getter/setter.

This is in conflict with the TalkatuMessage:id property which will be addressed in another review request but Pidgin seems to run fine right now with this conflict.

Compiled and ran locally against the history-api branch.

QuLogic
  1. Ship It!
  2. libpurple/purplemessage.c (Diff revision 1)
     
     

    Was this incorrectly not construct-only readwrite before?

    1. correct, we found out the hard way when unserializing messages via the history api.

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...