Summary

Update everything for GPlugin 0.33.0

Review Request #870 — Created Aug. 3, 2021 and submitted Aug. 4, 2021, 1:51 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

87fdacc5033a

Groups

People

Description

Update everything for GPlugin 0.33.0

Testing Done

Compiled and connected an XMPP account.

Issues

Description	From	Last Updated
You don't actually need to cast the first argument to g_signal_connect*.	QuLogic	Aug. 3, 2021, 10:58 p.m.
This is g_propagate_error?	QuLogic	Aug. 3, 2021, 10:58 p.m.
Ditto.	QuLogic	Aug. 3, 2021, 10:58 p.m.

finch/gntblist.c (Diff revision 1)

The issue has been resolved. Show all issues

You don't actually need to cast the first argument to g_signal_connect*.

I know, I put it in for consistency as most of our code does that... Is the current recommendation to not do it?

Yes, it seems like it, https://stackoverflow.com/a/21134442

libpurple/plugins.c (Diff revision 1)

The issue has been resolved. Show all issues

This is g_propagate_error?

Yeah I thought the same and meant to go back to it, will fix.

libpurple/plugins.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Ditto.
```

Commit:

21b30e7707f1

87fdacc5033a

Diff:

Ship it!