Update everything for GPlugin 0.33.0

Review Request #870 — Created Aug. 3, 2021 and submitted

grim
pidgin/pidgin
default
87fdacc5033a
pidgin
Update everything for GPlugin 0.33.0

Compiled and connected an XMPP account.

Description From Last Updated

You don't actually need to cast the first argument to g_signal_connect*.

QuLogicQuLogic

This is g_propagate_error?

QuLogicQuLogic

Ditto.

QuLogicQuLogic
QuLogic
  1. 
      
  2. finch/gntblist.c (Diff revision 1)
     
     

    You don't actually need to cast the first argument to g_signal_connect*.

    1. I know, I put it in for consistency as most of our code does that... Is the current recommendation to not do it?

    2. Yes, it seems like it, https://stackoverflow.com/a/21134442

  3. libpurple/plugins.c (Diff revision 1)
     
     
     
     
     

    This is g_propagate_error?

    1. Yeah I thought the same and meant to go back to it, will fix.

  4. libpurple/plugins.c (Diff revision 1)
     
     
     
     
     
  5. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...