Summary

Update everything for GPlugin 0.33.0

Review Request #870 — Created Aug. 3, 2021 and submitted Aug. 4, 2021, 1:51 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

87fdacc5033a

Reviewers

Groups

pidgin

People

Description

Update everything for GPlugin 0.33.0

Testing Done

Compiled and connected an XMPP account.

Issues

Description	From	Last Updated
You don't actually need to cast the first argument to g_signal_connect*.	QuLogic	Aug. 3, 2021, 10:58 p.m.
This is g_propagate_error?	QuLogic	Aug. 3, 2021, 10:58 p.m.
Ditto.	QuLogic	Aug. 3, 2021, 10:58 p.m.

finch/gntblist.c (Diff revision 1)

Show all issues

You don't actually need to cast the first argument to g_signal_connect*.

grim Aug. 3, 2021, 9:15 a.m.

I know, I put it in for consistency as most of our code does that... Is the current recommendation to not do it?

QuLogic Aug. 3, 2021, 10:57 p.m.

Yes, it seems like it, https://stackoverflow.com/a/21134442

libpurple/plugins.c (Diff revision 1)

Show all issues

This is g_propagate_error?

grim Aug. 3, 2021, 9:15 a.m.

Yeah I thought the same and meant to go back to it, will fix.

libpurple/plugins.c (Diff revision 1)
Show all issues
```
Ditto.
```

Commit:

-	21b30e7707f1
+	87fdacc5033a

Diff:

Revision 2 (+51 -35)

Show changes

	meson.build
	finch/gntblist.c
	finch/gntconv.c
	libpurple/plugins.c
	pidgin/gtkconv.c
	pidgin/pidginabout.c
	pidgin/pidginpluginsmenu.c
	subprojects/gplugin.wrap

Ship it!

```
Ship It!
```

Review Board 6.0.2

Update everything for GPlugin 0.33.0

Information

Reviewers

Commit:

Diff:

Status: Closed (submitted)