updated finch man page to refer to .gntrc at new location in ~/.config/gnt

Review Request #844 — Created July 26, 2021 and submitted

ivanhoe
pidgin/pidgin
default
850
fe3dd185942b
pidgin
updated finch man page to refer to .gntrc at new location in ~/.config/gnt


Description From Last Updated

If possible, I'd rather there be a General Paths kind of section, that describes that we follow XDG, etc., and ...

QuLogicQuLogic

Is it really a hidden .gntrc in the already hidden .config?

QuLogicQuLogic

\( is not a valid string escape.

QuLogicQuLogic

are these not used in the code anywhere? Seems like they would be unless it's just using the xdg stuff?

grimgrim

Should we highlight those paths somehow? Not sure how that might work in man pages (if there's some standard way ...

QuLogicQuLogic
QuLogic
  1. 
      
  2. doc/finch3.1.in (Diff revision 1)
     
     

    Is it really a hidden .gntrc in the already hidden .config?

    1. Yes it is. From gntmain.c:

      filename = g_build_filename(gnt_get_config_dir(), ".gntrc", NULL);
      gnt_style_read_configure_file(filename);
      
    2. Maybe the dot should be dropped. Apparently, using gnt_get_config_dir was introduced for Windows compatibility which doesn't always handle dot files that well anyway.

    3. Yes, we should fix that. The default path is hidden in .config already, so doesn't need the dot. If you pass a custom config dir, then it doesn't need to be hidden. And on Windows, the dot does nothing.

  3. 
      
ivanhoe
QuLogic
QuLogic
  1. 
      
  2. If possible, I'd rather there be a General Paths kind of section, that describes that we follow XDG, etc., and the default paths.

    And everywhere else just calls it gntrc without a path.

  3. meson.build (Diff revision 2)
     
     

    \( is not a valid string escape.

    1. What do you mean? \(rs is how you produce a backslash in nroff, I tested this and it produces a backslash.

    2. I guess this is a moot point now, since I removed that from the meson file again.

  4. 
      
ivanhoe
grim
  1. 
      
  2. meson.build (Diff revision 2)
     
     

    are these not used in the code anywhere? Seems like they would be unless it's just using the xdg stuff?

    1. This is the old revision, I think?

    2. hah I'm dumb and didn't realize that was going into the man_conf object...

  3. 
      
QuLogic
  1. 
      
  2. doc/finch3.1.in (Diff revision 3)
     
     

    Should we highlight those paths somehow? Not sure how that might work in man pages (if there's some standard way to do it or whatever.)

  3. 
      
ivanhoe
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...