Summary

updated finch man page to refer to .gntrc at new location in ~/.config/gnt

Review Request #844 — Created July 26, 2021 and submitted Aug. 14, 2021, 9:15 a.m.

Information

Owner

ivanhoe

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~850~~

Commit

fe3dd185942b

Reviewers

Groups

pidgin

People

Description

updated finch man page to refer to .gntrc at new location in ~/.config/gnt

Testing Done

Issues

Description	From	Last Updated
If possible, I'd rather there be a General Paths kind of section, that describes that we follow XDG, etc., and …	QuLogic	Aug. 3, 2021, 3:52 a.m.
Is it really a hidden .gntrc in the already hidden .config?	QuLogic	July 30, 2021, 7:29 p.m.
\( is not a valid string escape.	QuLogic	July 30, 2021, 7:31 p.m.
are these not used in the code anywhere? Seems like they would be unless it's just using the xdg stuff?	grim	Aug. 3, 2021, 7:19 a.m.
Should we highlight those paths somehow? Not sure how that might work in man pages (if there's some standard way …	QuLogic	Aug. 14, 2021, 8:10 a.m.

doc/finch3.1.in (Diff revision 1)

Show all issues

Is it really a hidden .gntrc in the already hidden .config?

ivanhoe July 26, 2021, 9:05 p.m.

Yes it is. From gntmain.c:
filename = g_build_filename(gnt_get_config_dir(), ".gntrc", NULL);
gnt_style_read_configure_file(filename);

ivanhoe July 26, 2021, 9:11 p.m.

Maybe the dot should be dropped. Apparently, using gnt_get_config_dir was introduced for Windows compatibility which doesn't always handle dot files that well anyway.

QuLogic July 26, 2021, 9:19 p.m.

Yes, we should fix that. The default path is hidden in .config already, so doesn't need the dot. If you pass a custom config dir, then it doesn't need to be hidden. And on Windows, the dot does nothing.

Change Summary:

removed dot from gntrc and made the file path a variable to account for different config location on Windows

Commit:

-	13bdb7e58cb4
+	60261b4b2a87

Diff:

Revision 2 (+11 -6)

Show changes

	meson.build
	doc/finch3.1.in

Depends On:

+	~~850 - removed dot from gntrc config file (see RR 844)~~

Show all issues

If possible, I'd rather there be a General Paths kind of section, that describes that we follow XDG, etc., and the default paths.

And everywhere else just calls it gntrc without a path.

meson.build (Diff revision 2)

Show all issues

\( is not a valid string escape.

ivanhoe July 28, 2021, 6:53 a.m.

What do you mean? \(rs is how you produce a backslash in nroff, I tested this and it produces a backslash.

ivanhoe July 30, 2021, 7:31 p.m.

I guess this is a moot point now, since I removed that from the meson file again.

Change Summary:

addressed Elliot's 2nd issue

Commit:

-	60261b4b2a87
+	f55e6b9687d1

Diff:

Revision 3 (+6 -6)

Show changes

doc/finch3.1.in

meson.build (Diff revision 2)

Show all issues

are these not used in the code anywhere? Seems like they would be unless it's just using the xdg stuff?

QuLogic Aug. 3, 2021, 3:52 a.m.
```
This is the old revision, I think?
```

grim Aug. 3, 2021, 7:19 a.m.

hah I'm dumb and didn't realize that was going into the man_conf object...

doc/finch3.1.in (Diff revision 3)

Show all issues

Should we highlight those paths somehow? Not sure how that might work in man pages (if there's some standard way to do it or whatever.)

Change Summary:

highlight gntrc paths

Commit:

-	f55e6b9687d1
+	fe3dd185942b

Diff:

Revision 4 (+6 -6)

Show changes

doc/finch3.1.in

Ship it!

```
Ship It!
```

Review Board 6.0.2

updated finch man page to refer to .gntrc at new location in ~/.config/gnt

Information

Reviewers

Change Summary:

Commit:

Diff:

Depends On:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Status: Closed (submitted)