Summary

Port the protocol plugins to the purple_conversation_manager_api

Review Request #829 — Created July 23, 2021 and submitted July 26, 2021, 9:16 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

533e4b588e8e

Groups

People

Description

Port the protocol plugins to the purple_conversation_manager_api

Testing Done

Connected an xmpp and irc account and verified chats and ims worked.

Issues

Description	From	Last Updated
room is used by purple_debug_info(), 5 lines up when it's always NULL.	jrchamp	July 26, 2021, 9:13 a.m.
Move inside the if?	QuLogic	July 26, 2021, 9:11 a.m.
Move into the if?	QuLogic	July 26, 2021, 9:11 a.m.
PURPLE_ACCOUNT?	QuLogic	July 26, 2021, 9:11 a.m.

Commit:

c6bbf3918a67

995735782d4d

Diff:

Revision 2 (+560 -219)

	libpurple/protocols/bonjour/xmpp.c
	libpurple/protocols/facebook/facebook.c
	libpurple/protocols/facebook/util.c
	libpurple/protocols/gg/chat.c
	libpurple/protocols/gg/image-prpl.c
	libpurple/protocols/gg/message-prpl.c
	libpurple/protocols/irc/cmds.c
	libpurple/protocols/irc/irc.c
	11 more

libpurple/protocols/irc/msgs.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Move inside the if?
```
libpurple/protocols/irc/msgs.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Move into the if?
```
libpurple/protocols/novell/novell.c (Diff revision 2)
The issue has been resolved. Show all issues
```
PURPLE_ACCOUNT?
```

Commit:

995735782d4d

533e4b588e8e

Diff:

Revision 3 (+562 -221)

	libpurple/protocols/bonjour/xmpp.c
	libpurple/protocols/facebook/facebook.c
	libpurple/protocols/facebook/util.c
	libpurple/protocols/gg/chat.c
	libpurple/protocols/gg/image-prpl.c
	libpurple/protocols/gg/message-prpl.c
	libpurple/protocols/irc/cmds.c
	libpurple/protocols/irc/irc.c
	11 more

Ship it!