Port the protocol plugins to the purple_conversation_manager_api

Review Request #829 — Created July 23, 2021 and submitted

Information

pidgin/pidgin
default
533e4b588e8e

Reviewers

Port the protocol plugins to the purple_conversation_manager_api

Connected an xmpp and irc account and verified chats and ims worked.

Description From Last Updated

room is used by purple_debug_info(), 5 lines up when it's always NULL.

jrchampjrchamp

Move inside the if?

QuLogicQuLogic

Move into the if?

QuLogicQuLogic

PURPLE_ACCOUNT?

QuLogicQuLogic
jrchamp
  1. 
      
  2. libpurple/protocols/null/nullprpl.c (Diff revision 1)
     
     

    room is used by purple_debug_info(), 5 lines up when it's always NULL.

  3. 
      
grim
QuLogic
  1. 
      
  2. libpurple/protocols/irc/msgs.c (Diff revision 2)
     
     

    Move inside the if?

  3. libpurple/protocols/irc/msgs.c (Diff revision 2)
     
     

    Move into the if?

  4. libpurple/protocols/novell/novell.c (Diff revision 2)
     
     

    PURPLE_ACCOUNT?

  5. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...