Update the transparency plugin so it'll load again.

Review Request #828 — Created July 23, 2021 and submitted

Information

pidgin/pidgin
default
5b4df915b145

Reviewers

Update the transparency plugin so it'll load again.

Ran and loaded the plugin, but was unable to actually test it because the configuration frames for plugins are currently not working.

Description From Last Updated

Shouldn't this be PIDGIN_IS_BUDDY_LIST?

QuLogicQuLogic

I wonder if we even need this, if we have it packed with expanding on?

QuLogicQuLogic

The comment too.

QuLogicQuLogic

Don't appear to need this either.

QuLogicQuLogic

Probably same question about packing, but I guess you can't tell if it's not showing up anywhere.

QuLogicQuLogic
QuLogic
  1. 
      
  2. pidgin/plugins/transparency.c (Diff revision 1)
     
     
    Show all issues

    Shouldn't this be PIDGIN_IS_BUDDY_LIST?

  3. pidgin/plugins/transparency.c (Diff revision 1)
     
     
    Show all issues

    I wonder if we even need this, if we have it packed with expanding on?

  4. pidgin/plugins/transparency.c (Diff revision 1)
     
     
     
     
    Show all issues

    Don't appear to need this either.

  5. pidgin/plugins/transparency.c (Diff revision 1)
     
     
    Show all issues

    Probably same question about packing, but I guess you can't tell if it's not showing up anywhere.

  6. 
      
grim
QuLogic
  1. 
      
  2. pidgin/plugins/transparency.c (Diff revisions 1 - 2)
     
     
    Show all issues

    The comment too.

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed