Make the basic plugins verify that they've been called with the correct parameters

Review Request #817 — Created July 16, 2021 and submitted

grim
gplugin/gplugin
default
2f2de600aabe
pidgin
Make the basic plugins verify that they've been called with the correct parameters

Ran the unit tests but the perl load is being a pain and I'm considering dropping it. See the comment in the code for more information.

  • 0
  • 0
  • 4
  • 1
  • 5
Description From Last Updated
QuLogic
  1. 
      
  2. gplugin/tests/plugins/basic-plugin.c (Diff revision 1)
     
     

    Could be g_set_error_literal

  3. gplugin/tests/plugins/basic-plugin.c (Diff revision 1)
     
     
  4. perl5/gplugin-perl5-loader.c (Diff revision 1)
     
     
     
     

    Huh? If error == NULL, then g_set_error_literal will do nothing. Is this supposed to check *error?

  5. perl5/gplugin-perl5-loader.c (Diff revision 1)
     
     
     

    Why is this one with extra description, when the load one just does g_set_error_literal?

    1. i think this was changed during testing.

  6. perl5/gplugin-perl5-loader.c (Diff revision 1)
     
     

    Hmm, so this one doesn't need the weird g_message?

  7. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...