Summary

Fix invalid reads/writes when hiding widget in Finch

Review Request #810 — Created July 13, 2021 and submitted July 15, 2021, 6:02 a.m.

Information

Owner

ivanhoe

Repository

libgnt/libgnt

Branch

release-2.x.y

Bugs

LIBGNT-13

Depends On

Commit

658c31365bda

Reviewers

Groups

pidgin

People

Description

Fix invalid reads/writes when hiding widget in Finch

Testing Done

ran "steps to reproduce" from LIBGNT-13 without getting invalid reads/writes anymore.

Issues

Description	From	Last Updated
this should probably use g_clear_pointer(&obj->window, gnt_widget_hide); instead.	grim	July 13, 2021, 9:15 p.m.

Summary:

-	attempt to fix LIBGNT-13
+	Fix invalid reads/writes when hiding widget in Finch

Description:

~		attempt to fix LIBGNT-13
	~	Fix invalid reads/writes when hiding widget in Finch

Testing Done:

~		ran "steps to reproduce" from https://issues.imfreedom.org/issue/LIBGNT-13 without getting invalid reads/writes anymore
	~	ran "steps to reproduce" from LIBGNT-13 without getting invalid reads/writes anymore.

Bugs:

+	LIBGNT-13

gntwidget.c (Diff revision 1)

Show all issues

this should probably use g_clear_pointer(&obj->window, gnt_widget_hide); instead.

ivanhoe July 13, 2021, 9:06 p.m.

I think it should be delwin instead of gnt_widget_hide.

grim July 14, 2021, 12:06 a.m.
```
Yep sorry not sure how I typed that :-D
```

Change Summary:

use g_clear_pointer

Commit:

-	d70de31a9e2e
+	658c31365bda

Diff:

Revision 2 (+4 -2)

Show changes

gntwidget.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Fix invalid reads/writes when hiding widget in Finch

Information

Reviewers

Summary:

Description:

Testing Done:

Bugs:

Change Summary:

Commit:

Diff:

Status: Closed (submitted)