Summary

Fix invalid reads/writes when hiding widget in Finch

Review Request #810 — Created July 13, 2021 and submitted July 15, 2021, 1:02 a.m.

Owner

Repository

libgnt/libgnt

Branch

release-2.x.y

Bugs

Depends On

Commit

658c31365bda

Groups

People

Description

Fix invalid reads/writes when hiding widget in Finch

Testing Done

ran "steps to reproduce" from LIBGNT-13 without getting invalid reads/writes anymore.

Issues

Description	From	Last Updated
this should probably use g_clear_pointer(&obj->window, gnt_widget_hide); instead.	grim	July 13, 2021, 4:15 p.m.

Summary:: attempt to fix LIBGNT-13
Fix invalid reads/writes when hiding widget in Finch
Description:: ~
attempt to fix LIBGNT-13
~
Fix invalid reads/writes when hiding widget in Finch
Testing Done:: ~
ran "steps to reproduce" from https://issues.imfreedom.org/issue/LIBGNT-13 without getting invalid reads/writes anymore
~
ran "steps to reproduce" from LIBGNT-13 without getting invalid reads/writes anymore.
Bugs:: LIBGNT-13

gntwidget.c (Diff revision 1)

The issue has been resolved. Show all issues

this should probably use g_clear_pointer(&obj->window, gnt_widget_hide); instead.

I think it should be delwin instead of gnt_widget_hide.

Change Summary:

use g_clear_pointer

Commit:

d70de31a9e2e

658c31365bda

Diff:

Ship it!

~		attempt to fix LIBGNT-13
	~	Fix invalid reads/writes when hiding widget in Finch

~		ran "steps to reproduce" from https://issues.imfreedom.org/issue/LIBGNT-13 without getting invalid reads/writes anymore
	~	ran "steps to reproduce" from LIBGNT-13 without getting invalid reads/writes anymore.