Move minidialog stuff from utils to its source file

Review Request #788 — Created July 3, 2021 and submitted

QuLogic
pidgin/pidgin
default
pidgin
  • Remove minidialog list from utils.
    It's supposed to be used to delete them when the connection is dropped, but this list is never added to. And the dialogs are automatically closed when the account disconnects in some other way that I could not find.
    Consequently, drop the unused gc from pidgin_make_mini_dialog*.
  • Replace PidginUtilMiniDialogCallback by PidginMiniDialogCallback.
    It is just a wrapper around the latter, with different argument order.
  • Move minidialog wrappers from utils to minidialog.c. And fix naming/arguments to match the existing functions.

Compiled, connected an account that had buddy requests, but didn't act on them.

  • 0
  • 0
  • 3
  • 4
  • 7
Description From Last Updated
grim
  1. 
      
  2. Did you test a connection failure at all?

    1. I tested a connection to an invalid server, which added the dialog as expected, as well as an invalid password.

  3. pidgin/gtkaccount.c (Diff revision 1)
     
     

    I'm confused why the new parameters were added...

    1. From removing PidginUtilMiniDialog.

    2. PidginUtilMiniDialogCallback*

  4. pidgin/gtkaccount.c (Diff revision 1)
     
     

    No typecast?

    1. They're not gobjects and user_data is a gpointer, so it's not needed.

  5. pidgin/gtkaccount.c (Diff revision 1)
     
     

    No type cast?

  6. pidgin/gtkaccount.c (Diff revision 1)
     
     

    typecast?

  7. pidgin/gtkaccount.c (Diff revision 1)
     
     

    typecast?

  8. pidgin/minidialog.c (Diff revision 1)
     
     
  9. 
      
QuLogic
grim
  1. Ship It!
  2. Awesome work, thanks!!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...