Summary

Move minidialog stuff from utils to its source file

Review Request #788 — Created July 3, 2021 and submitted July 23, 2021, 3:34 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description


Remove minidialog list from utils.

  It's supposed to be used to delete them when the connection is dropped, but this list is never added to. And the dialogs are automatically closed when the account disconnects in some other way that I could not find.

  Consequently, drop the unused gc from pidgin_make_mini_dialog*.
Replace PidginUtilMiniDialogCallback by PidginMiniDialogCallback.

  It is just a wrapper around the latter, with different argument order.
Move minidialog wrappers from utils to minidialog.c. And fix naming/arguments to match the existing functions.

Testing Done

Compiled, connected an account that had buddy requests, but didn't act on them.

Issues

Description	From	Last Updated
Did you test a connection failure at all?	grim	July 23, 2021, 3:33 a.m.
I'm confused why the new parameters were added...	grim	July 10, 2021, 4:39 a.m.
No typecast?	grim	July 10, 2021, 4:39 a.m.
No type cast?	grim	July 10, 2021, 4:39 a.m.
typecast?	grim	July 10, 2021, 4:39 a.m.
typecast?	grim	July 10, 2021, 4:39 a.m.
gchar	grim	July 23, 2021, 3:32 a.m.

The issue has been resolved. Show all issues

Did you test a connection failure at all?

QuLogic July 23, 2021, 3:32 a.m.

I tested a connection to an invalid server, which added the dialog as expected, as well as an invalid password.

pidgin/gtkaccount.c (Diff revision 1)
The issue has been resolved. Show all issues
```
I'm confused why the new parameters were added...
```
1. QuLogic July 4, 2021, 6:52 a.m.
  From removing PidginUtilMiniDialog.
2. QuLogic July 4, 2021, 6:52 a.m.
  PidginUtilMiniDialogCallback*
pidgin/gtkaccount.c (Diff revision 1)
The issue has been dropped. Show all issues
```
No typecast?
```
1. QuLogic July 4, 2021, 6:52 a.m.
  They're not gobjects and user_data is a gpointer, so it's not needed.
pidgin/gtkaccount.c (Diff revision 1)
The issue has been dropped. Show all issues
```
No type cast?
```
pidgin/gtkaccount.c (Diff revision 1)
The issue has been dropped. Show all issues
```
typecast?
```
pidgin/gtkaccount.c (Diff revision 1)
The issue has been dropped. Show all issues
```
typecast?
```
pidgin/minidialog.c (Diff revision 1)
The issue has been resolved. Show all issues
```
gchar
```

Diff:

Revision 2 (+119 -225)

Show changes

	ChangeLog.API
	pidgin/gtkaccount.c
	pidgin/gtkblist.c
	pidgin/gtkutils.h
	pidgin/gtkutils.c
	pidgin/minidialog.h
	pidgin/minidialog.c
	pidgin/plugins/relnot.c

Ship it!

```
Ship It!
```
```
Awesome work, thanks!!
```

Status:: Completed

pidgin/gtkaccount.c (Diff revision 1)

pidgin/gtkaccount.c (Diff revision 1)

pidgin/gtkaccount.c (Diff revision 1)

pidgin/gtkaccount.c (Diff revision 1)